hieradata-overrides-t-h-t-undercloud is not counted in for undercloud install --use-heat

[Bogdan Dobrelya]

hieradata-overrides-t-h-t-undercloud created by quickstart should be counted in for --use-heat as well. For now, it is only used with undercloud deploy script.

And heat installer instead consumes it from undercloud.conf:
hieradata_override = hieradata-overrides-classic-undercloud.yaml

which is supposed to be used with legacy instack installations only.

There is a related bug https://bugs.launchpad.net/tripleo/+bug/1766579. Once it is fixed, quickstart should start using the single hieradata-overrides-t-h-t-undercloud file passed via undercloud.conf (for Rocky and later)

[Bogdan Dobrelya (bogdando)]

@quiquell if you want to take over it for quickstart-extras, go for it, the required tripleoclient change is submitted for merge https://review.openstack.org/#/c/563986

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/564835

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/564835
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=355859beafaaf7c87dcb405e8543f3ba0895c8c8
Submitter: Zuul
Branch: master

commit 355859beafaaf7c87dcb405e8543f3ba0895c8c8
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Apr 27 17:57:27 2018 +0200

    Fix hieradata overrides for UC instack/heat install

    Complement Idf595498e46eeb88acfd4c3a21094d22197a6d7b
    and make sure heat installer takes a valid hieradata
    override file depending on config vars setup.

    Update README as well to explain the cases better.

    Closes-bug: #1766579
    Closes-bug: #1766848

    Change-Id: Id821f613fe72e2f768f80acaa5657a8be86879b7
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.