tripleo

tht YAML validation may pass a full run and fail a targeted check

Bug #1764741 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Bogdan Dobrelya
tripleo rocky-1

Bug Description

Say, the command may fail as expected:

python ./tools/yaml-validate.py -- puppet/services/snmp.yaml

but passes when running a full check:

python ./tools/yaml-validate.py .

The issue us that the validate function tracks only the most recent retval and some of the included checks may have its complex logic built on relations for the consequent retval results.

To mitigate that, we should introduce a global failures flag and start tracking it as well.

See original description
Bogdan Dobrelya (bogdando)
Changed in tripleo:
status: New → Triaged
importance: Undecided → Medium
milestone: none → rocky-1
Bogdan Dobrelya (bogdando)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/561965

Changed in tripleo:
assignee: nobody → Bogdan Dobrelya (bogdando)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/561965
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b079bcc3e1a08fa4c260bc4c88b9f5faf05b5673
Submitter: Zuul
Branch: master

commit b079bcc3e1a08fa4c260bc4c88b9f5faf05b5673
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Apr 17 16:14:17 2018 +0200

    Track global failures flag for YAML validations

    Closes-bug: #1764741

    Change-Id: Id0313cde5e1d86103940ff4f77f09b79d0d04ec3
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.0.0.0b3

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/692230

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.opendev.org/692230
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a0d11968fcee50c3c6de092692a8a7acc52f0f41
Submitter: Zuul
Branch: stable/queens

commit a0d11968fcee50c3c6de092692a8a7acc52f0f41
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Apr 17 16:14:17 2018 +0200

    Track global failures flag for YAML validations

    Closes-bug: #1764741

    Change-Id: Id0313cde5e1d86103940ff4f77f09b79d0d04ec3
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit b079bcc3e1a08fa4c260bc4c88b9f5faf05b5673)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates queens-eol

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.