poor use of variable names in tripleo_upgrade role re: triple_ci variable

Bug #1764476 reported by wes hayutin on 2018-04-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Medium
Unassigned

Bug Description

https://github.com/openstack/tripleo-upgrade/blame/master/README.md#L110

    tripleo_ci: false

Set to true when running the role in the TripleO CI jobs. It avoids losing connectivity to the undercloud by skipping reboot and ssh kill tasks.

whayutin•RDO-CI/TRIPLEO-QUICKSTART/tripleo-upgrade ᐅ egrep -rn tripleo_ci *  master✔ thinkdoe ⌚ 13:50:33
defaults/main.yml:40:tripleo_ci: false
README.md:110: tripleo_ci: false
tasks/update/main.yml:50: when: tripleo_ci|default(false)|bool
tasks/upgrade/main.yml:41: when: tripleo_ci|default(false)|bool
tasks/upgrade/kill_ssh.yaml:6: when: not tripleo_ci
tasks/common/undercloud_validate_upgrade.yaml:93: - not tripleo_ci and (undercloud_reboot or (installed_kernel.stdout != loaded_kernel.stdout) or (installed_ovs.stdout != loaded_ovs.stdout))
tasks/fast-forward-upgrade/create-prepare-scripts.yaml:86: - tripleo_ci|bool
tasks/fast-forward-upgrade/main.yml:78: when: tripleo_ci|default(false)|bool

Variable names should be specific to their function. Instead of using tripleo_ci|bool I would suggest..

undercloud_reboot|bool
ssh_kill|bool

Changed in tripleo:
milestone: none → rocky-2
Changed in tripleo:
milestone: rocky-2 → rocky-3
Changed in tripleo:
milestone: rocky-3 → rocky-rc1
Changed in tripleo:
milestone: rocky-rc1 → stein-1
Changed in tripleo:
milestone: stein-1 → stein-2
Changed in tripleo:
milestone: stein-2 → stein-3
Changed in tripleo:
milestone: stein-3 → train-1
Changed in tripleo:
milestone: train-1 → train-2
Changed in tripleo:
milestone: train-2 → train-3
Changed in tripleo:
milestone: train-3 → ussuri-1
Changed in tripleo:
milestone: ussuri-1 → ussuri-2
wes hayutin (weshayutin) on 2020-02-10
Changed in tripleo:
milestone: ussuri-2 → ussuri-3
wes hayutin (weshayutin) on 2020-04-13
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
wes hayutin (weshayutin) on 2020-05-11
Changed in tripleo:
status: Triaged → Incomplete
wes hayutin (weshayutin) on 2020-05-26
Changed in tripleo:
milestone: ussuri-rc3 → victoria-1
Changed in tripleo:
milestone: victoria-1 → victoria-3
Changed in tripleo:
milestone: victoria-3 → wallaby-1
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers