poor use of variable names in tripleo_upgrade role re: triple_ci variable

[wes hayutin]

https://github.com/openstack/tripleo-upgrade/blame/master/README.md#L110

    tripleo_ci: false

Set to true when running the role in the TripleO CI jobs. It avoids losing connectivity to the undercloud by skipping reboot and ssh kill tasks.

whayutin•RDO-CI/TRIPLEO-QUICKSTART/tripleo-upgrade ᐅ egrep -rn tripleo_ci *  master✔ thinkdoe ⌚ 13:50:33
defaults/main.yml:40:tripleo_ci: false
README.md:110: tripleo_ci: false
tasks/update/main.yml:50: when: tripleo_ci|default(false)|bool
tasks/upgrade/main.yml:41: when: tripleo_ci|default(false)|bool
tasks/upgrade/kill_ssh.yaml:6: when: not tripleo_ci
tasks/common/undercloud_validate_upgrade.yaml:93: - not tripleo_ci and (undercloud_reboot or (installed_kernel.stdout != loaded_kernel.stdout) or (installed_ovs.stdout != loaded_ovs.stdout))
tasks/fast-forward-upgrade/create-prepare-scripts.yaml:86: - tripleo_ci|bool
tasks/fast-forward-upgrade/main.yml:78: when: tripleo_ci|default(false)|bool

Variable names should be specific to their function. Instead of using tripleo_ci|bool I would suggest..

undercloud_reboot|bool
ssh_kill|bool

[Marios Andreou (marios-b)]

This is an automated action. Bug status has been set to 'Incomplete' and target milestone has been removed due to inactivity. If you disagree please re-set these values and reach out to us on freenode #tripleo

[Launchpad Janitor (janitor)]

[Expired for tripleo because there has been no activity for 60 days.]