OpenDaylight OvsVhostuserMode is backwards

Bug #1762473 reported by Tim Rozet on 2018-04-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Tim Rozet

Bug Description

The current parameter suggests that the configuration is determining the client/server mode of OVS:
  OvsVhostuserMode:
    description: Specify the mode for OVS with vhostuser port creation. In
                 client mode, the hypervisor will be responsible for creating
                 vhostuser sockets. In server mode, OVS will create them.
    type: string
    default: "client"
    constraints:
      - allowed_values: [ 'client', 'server' ]

However, this configuration actually specifies the mode of the VIF relative to Nova/QEMU. So therefore configuring 'server' here will make OVS the client. This description needs to be updated, and the default value needs to be changed as 'client' mode is deprecated:

http://docs.openvswitch.org/en/latest/topics/dpdk/vhost-user/
"Use of vhost-user ports requires QEMU >= 2.2; vhost-user ports are deprecated."

Reviewed: https://review.openstack.org/559789
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2ecf3ac88bcdbab60b7f292ce635915c99acebc8
Submitter: Zuul
Branch: master

commit 2ecf3ac88bcdbab60b7f292ce635915c99acebc8
Author: Tim Rozet <email address hidden>
Date: Mon Apr 9 12:40:45 2018 -0400

    Fixes the OvsVhostuserMode heat parameter

    The mode was incorrectly defined as configuring the mode for OVS when it
    is really configuring the client/server mode for QEMU. A value of
    'client' here will cause OVS to create the vhostuser socket, and
    actually make OVS the server. This type of port is deprecated so the
    default should be 'server' (QEMU creates the port).

    Closes-Bug: 1762473

    Change-Id: I7cd34b30f54766fe35e4a40a57b278166d0197cb
    Signed-off-by: Tim Rozet <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/559986
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c80ce856476d56d36f643c415c049fccdf498762
Submitter: Zuul
Branch: stable/queens

commit c80ce856476d56d36f643c415c049fccdf498762
Author: Tim Rozet <email address hidden>
Date: Mon Apr 9 12:40:45 2018 -0400

    Fixes the OvsVhostuserMode heat parameter

    The mode was incorrectly defined as configuring the mode for OVS when it
    is really configuring the client/server mode for QEMU. A value of
    'client' here will cause OVS to create the vhostuser socket, and
    actually make OVS the server. This type of port is deprecated so the
    default should be 'server' (QEMU creates the port).

    Closes-Bug: 1762473

    Change-Id: I7cd34b30f54766fe35e4a40a57b278166d0197cb
    Signed-off-by: Tim Rozet <email address hidden>
    (cherry picked from commit 2ecf3ac88bcdbab60b7f292ce635915c99acebc8)

tags: added: in-stable-queens

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b2 development milestone.

This issue was fixed in the openstack/tripleo-heat-templates 8.0.2 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers