hieradata prepends an invalid comment to UUID when SMBIOS is newer then dmidecode supports

[Alex Schultz]

If the SMBIOS of a host is newer than is supported by the installed version of dmidecode, an invalid entry is included before the UUID in a node's heiradata. For example:

---
# SMBIOS implementations newer than version 2.8 are not# fully supported by this version of dmidecode.<UUID>
---

This impacts the pre_deploy per_node.yaml phase of an overcloud deployment because host UUIDs are not valid.

One potential solution could be for dmidecode to be updated prior to running pre_deploy per_node.yaml.

The '#SMBIOS implementations newer than version 2.8 are not# fully supported by this version of dmidecode.' comment is included in the UUID string in hieradata.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/559770

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/559770
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=dc3781778e1fef0fcb0e969d821d36b0fe03a6da
Submitter: Zuul
Branch: master

commit dc3781778e1fef0fcb0e969d821d36b0fe03a6da
Author: Alex Schultz <email address hidden>
Date: Mon Apr 9 09:35:43 2018 -0600

    Sanitize the uuid string

    dmidecode can return some additional data if SMBIOS is updated. Let's
    ensure that the expected output matches the expected UUID format. The
    expected string from the 'dmidecode --s system-uuid' call should look
    like "79287E4C-2FBF-11B2-A85C-EB9FB9250CBA".

    Change-Id: Ib0d19e64b2f24f4a9229f8868795e8979e267f04
    Closes-Bug: #1762460

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/635448

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/636125

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/636125
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=90c456463862fdedbb709966ead479051ed459a7
Submitter: Zuul
Branch: stable/rocky

commit 90c456463862fdedbb709966ead479051ed459a7
Author: Giulio Fidente <email address hidden>
Date: Thu Feb 7 09:01:32 2019 +0100

    Sanitize the uuid string for ceph-ansible

    dmidecode can return some additional data if SMBIOS is updated; this
    ensures output matches the UUID format.

    Change-Id: I5c61c0049bfd16114894cf4db3b79f94b6d9291b
    Related-Bug: 1762460
    (cherry picked from commit ad803ab716448e2dfaa446d732f64c6bd851cb05)