Make setting for ulimit configurable via THT parameter

[yatin]

Currently 1024 is set as the nofile ulimit for neutron containers([1]), it would be good to Create it configurable via a THT Parameter so that it can be changed as per environment or when required(overcloud update)

As performance issue is seen in other services also such similar settings would be required for them as well.

So something like parameters can be created for doing the ulimit configuration per service/container basis:-
NeutronDhcpContainerUlimit: ['nofile=1024', 'nproc=1024']
NeutronL3AgentUlimit: ['nofile=2048']

[1] https://review.openstack.org/#/c/559268/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/560359

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/560991

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/560991
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ca09d08bf782ad2e9c762fb8f945c06119bd9c28
Submitter: Zuul
Branch: stable/queens

commit ca09d08bf782ad2e9c762fb8f945c06119bd9c28
Author: yatin <email address hidden>
Date: Wed Apr 11 15:53:22 2018 +0530

    Set ulimit for nova-compute and cinder-volume

    Nova compute and cinder volume uses oslo concurrency
    processuitls.execute to run privileged commands.
    Containers inherit file descriptor limit from docker daemon
    (currently:1048576) which is too high and leads to performance
    issue. This patch sets nofile limit to 1024 for nova compute
    and 131072 for cinder volume, which is reasonable as before
    containers nova compute used host defaults i.e 1024 and cinder
    volume systemctl override([1]) i.e 131072. Also updated neutron
    l3, dhcp and ovs agent to use Parameters for ulimit configuration.

    [1] https://review.rdoproject.org/r/#/c/1360/.

    Closes-Bug: #1762455
    Related-Bug: #1760471
    Related-Bug: #1757556
    Change-Id: I4d4b36de32f8a8e311efd87ea1c4095c5568dec4

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/560359
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=70276931a4664d0bedcd6b0caa5a9cac2b73187b
Submitter: Zuul
Branch: master

commit 70276931a4664d0bedcd6b0caa5a9cac2b73187b
Author: yatin <email address hidden>
Date: Wed Apr 11 15:53:22 2018 +0530

    Set ulimit for nova-compute and cinder-volume

    Nova compute and cinder volume uses oslo concurrency
    processuitls.execute to run privileged commands.
    Containers inherit file descriptor limit from docker daemon
    (currently:1048576) which is too high and leads to performance
    issue. This patch sets nofile limit to 1024 for nova compute
    and 131072 for cinder volume, which is reasonable as before
    containers nova compute used host defaults i.e 1024 and cinder
    volume systemctl override([1]) i.e 131072. Also updated neutron
    l3, dhcp and ovs agent to use Parameters for ulimit configuration.

    [1] https://review.rdoproject.org/r/#/c/1360/.

    Closes-Bug: #1762455
    Related-Bug: #1760471
    Related-Bug: #1757556
    Change-Id: I4d4b36de32f8a8e311efd87ea1c4095c5568dec4

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.2 release.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/668416

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/668457

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/668416
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8ef4f3cac8ad2ded4214a3ee26cd919ace0af9be
Submitter: Zuul
Branch: master

commit 8ef4f3cac8ad2ded4214a3ee26cd919ace0af9be
Author: Bogdan Dobrelya <email address hidden>
Date: Mon Jul 1 12:44:15 2019 +0200

    Add ContainerNovaLibvirtUlimit to tweak Ulimits

    Ulimit defaults in Kolla for libvirt container provide sub-uptimal
    performance. Allow to override those and also provide opinionated
    defaults for TripleO. Keep those defaults in sync with that we need
    in the nova-compute & cinder-volume containers to avoid potential
    issues with ceph.

    Related: https://bugzilla.redhat.com/show_bug.cgi?id=1721434

    Related-bug: #1762455

    Change-Id: I7fa26a8d9d3b4029bdd518409013246720b057e3
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/668688

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/668690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/668690
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=581d2d544928c75de8c20f68c90846c4f9e9bfae
Submitter: Zuul
Branch: stable/stein

commit 581d2d544928c75de8c20f68c90846c4f9e9bfae
Author: Bogdan Dobrelya <email address hidden>
Date: Mon Jul 1 12:44:15 2019 +0200

    Add ContainerNovaLibvirtUlimit to tweak Ulimits

    Ulimit defaults in Kolla for libvirt container provide sub-uptimal
    performance. Allow to override those and also provide opinionated
    defaults for TripleO. Keep those defaults in sync with that we need
    in the nova-compute & cinder-volume containers to avoid potential
    issues with ceph.

    Related: https://bugzilla.redhat.com/show_bug.cgi?id=1721434

    Related-bug: #1762455

    Change-Id: I7fa26a8d9d3b4029bdd518409013246720b057e3
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 8ef4f3cac8ad2ded4214a3ee26cd919ace0af9be)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/668688
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=27cbefab71737b1970bf371b746041d6d332ccce
Submitter: Zuul
Branch: stable/rocky

commit 27cbefab71737b1970bf371b746041d6d332ccce
Author: Bogdan Dobrelya <email address hidden>
Date: Mon Jul 1 12:44:15 2019 +0200

    Add ContainerNovaLibvirtUlimit to tweak Ulimits

    Ulimit defaults in Kolla for libvirt container provide sub-uptimal
    performance. Allow to override those and also provide opinionated
    defaults for TripleO. Keep those defaults in sync with that we need
    in the nova-compute & cinder-volume containers to avoid potential
    issues with ceph.

    Related: https://bugzilla.redhat.com/show_bug.cgi?id=1721434

    Related-bug: #1762455

    Change-Id: I7fa26a8d9d3b4029bdd518409013246720b057e3
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 8ef4f3cac8ad2ded4214a3ee26cd919ace0af9be)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/668457
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7ad2741d5e3585589359868b3ab00b783971d61e
Submitter: Zuul
Branch: stable/queens

commit 7ad2741d5e3585589359868b3ab00b783971d61e
Author: Bogdan Dobrelya <email address hidden>
Date: Mon Jul 1 12:44:15 2019 +0200

    Add ContainerNovaLibvirtUlimit to tweak Ulimits

    Ulimit defaults in Kolla for libvirt container provide sub-uptimal
    performance. Allow to override those and also provide opinionated
    defaults for TripleO. Keep those defaults in sync with that we need
    in the nova-compute & cinder-volume containers to avoid potential
    issues with ceph.

    Related: https://bugzilla.redhat.com/show_bug.cgi?id=1721434

    Related-bug: #1762455

    Change-Id: I7fa26a8d9d3b4029bdd518409013246720b057e3
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 8ef4f3cac8ad2ded4214a3ee26cd919ace0af9be)