[CI ocata->pike] Undefined variable 'deploy_config_name'

[Jose Luis Franco]

Existing Ocata->Pike CI job is failing during upgrade step with the following error:

            "Debug: importing '/etc/puppet/modules/tripleo/manifests/profile/base/cinder/volume.pp' in environment production",
            "Debug: Automatically imported tripleo::profile::base::cinder::volume from tripleo/profile/base/cinder/volume into production",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::cinder_enable_dellsc_backend in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::cinder_enable_dellemc_vmax_iscsi_backend in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::cinder_enable_hpelefthand_backend in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::cinder_enable_dellps_backend in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::cinder_enable_iscsi_backend in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::cinder_enable_netapp_backend in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::cinder_enable_nfs_backend in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::cinder_enable_rbd_backend in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::cinder_enable_scaleio_backend in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::cinder_user_enabled_backends in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::cinder_rbd_client_name in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::step in JSON backend",
            "Debug: hiera(): Looking up cinder_user_enabled_backends in JSON backend",
            "Debug: hiera(): Looking up tripleo::profile::base::cinder::volume::rbd::cinder_rbd_user_name in JSON backend",
            "Warning: Undefined variable 'deploy_config_name'; ",
            " (file & line not available)",
            "Error: Evaluation Error: Error while evaluating a Function Call, Could not find class ::tripleo::profile::base::docker for upstream-centos-7-2-node-rdo-cloud-tripleo-113042-23823.localdomain at /var/lib/tripleo-config/puppet_step_config.pp:6:1 on node upstream-centos-7-2-node-rdo-cloud-tripleo-113042-23823.localdomain"

Logs to CI job: https://logs.rdoproject.org/93/554993/1/openstack-check/gate-tripleo-ci-centos-7-containers-multinode-upgrades-pike-nv/Z6cd9b7d106f740c69377a194859001a7/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/556886

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/556886
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=6f5f26b13b627d797fcc15ed4d876f047de0fa1a
Submitter: Zuul
Branch: master

commit 6f5f26b13b627d797fcc15ed4d876f047de0fa1a
Author: Jose Luis Franco Arza <email address hidden>
Date: Tue Mar 27 17:13:43 2018 +0200

    Add missing dash in repo-setup task.

    Adding missing dash from [0] which was blocking
    the execution of repo-setup to generate the
    repo-script used in O->P upgrades job.

    [0] - https://review.openstack.org/#/c/549414/

    Change-Id: I033ec0d0dd4fbf26b7231ca48d73f28c12e78b0f
    Closes-Bug: #1757969

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.