tripleo

remove ownership change of ironic-dbsync.log during upgrade

Bug #1754658 reported by Radoslaw Smigielski on 2018-03-09

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Medium	Radoslaw Smigielski	tripleo rocky-1

Bug Description

In Rocky we can remove workaround for https://review.openstack.org/#/c/457478/.

/var/log/ironic/ironic-dbsync.log owned by root:root instead of ironic:ironic.

basically revert commit 6a46ec6190b1d9c8ad546b72c9f6158ada9be6ef.

Tags:

Radoslaw Smigielski (radoslaw-smigielski) on 2018-03-09

Changed in tripleo:
assignee:	nobody → Radoslaw Smigielski (radoslaw-smigielski)
assignee:	Radoslaw Smigielski (radoslaw-smigielski) → nobody
status:	New → In Progress

Radoslaw Smigielski (radoslaw-smigielski) on 2018-03-09

Changed in tripleo:
assignee:	nobody → Radoslaw Smigielski (radoslaw-smigielski)
summary:	- remove ownership change for ironic-dbsync.log during upgrade + remove ownership change of ironic-dbsync.log during upgrade

Revision history for this message

Radoslaw Smigielski (radoslaw-smigielski) wrote on 2018-03-09:

Don't know why infra did not pick up my review:
https://review.openstack.org/#/c/551283/

Bogdan Dobrelya (bogdando) on 2018-03-09

Changed in tripleo:
importance:	Undecided → Medium
milestone:	none → rocky-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-03-12: Fix merged to instack-undercloud (master)

Reviewed: https://review.openstack.org/551283
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=410b9ceb026c4e6d21c8a8285f94b6244e901686
Submitter: Zuul
Branch: master

commit 410b9ceb026c4e6d21c8a8285f94b6244e901686
Author: Radoslaw Smigielski <email address hidden>
Date: Fri Mar 9 13:52:51 2018 +0000

remove ownership change of ironic-dbsync.log

Remove workaround https://review.openstack.org/#/c/457478/
we don't need it any more in Rocky.

Change-Id: Idb428e1a7a0cb37d9e7e2cbaa4c9a26efaf2bb34
Closes-bug: #1754658

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-04-19: Fix included in openstack/instack-undercloud 9.0.0

This issue was fixed in the openstack/instack-undercloud 9.0.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-06-23: Fix proposed to instack-undercloud (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/737639

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-06-24: Fix merged to instack-undercloud (stable/queens)

Reviewed: https://review.opendev.org/737639
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=77955bdc85acf12b30422ec8d4989bf9fb543298
Submitter: Zuul
Branch: stable/queens

commit 77955bdc85acf12b30422ec8d4989bf9fb543298
Author: Radoslaw Smigielski <email address hidden>
Date: Fri Mar 9 13:52:51 2018 +0000

remove ownership change of ironic-dbsync.log

    Remove workaround https://review.openstack.org/#/c/457478/
    we don't need it any more in Rocky since the puppet fix was backported
    to Newton and the workaround here has a comment that it can be removed
    after the Pike release.

This workaround is causing an undercloud upgrade issue where the
existing logs were removed before upgrade.

    Change-Id: Idb428e1a7a0cb37d9e7e2cbaa4c9a26efaf2bb34
    Closes-bug: #1754658
    (cherry picked from commit 410b9ceb026c4e6d21c8a8285f94b6244e901686)