Failed to prepare oc upgrade : Error in EndpointMap output endpoint_map: Invalid URL port

[Yurii Prokulevych]

Description of problem:
------------------------
Attempt to prepare oc for upgrade failed:

openstack overcloud upgrade prepare \
--validation-errors-nonfatal --templates \
--container-registry-file /home/stack/virt/docker-images-13.yaml \
-e /home/stack/virt/missed-images.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml \
-e /home/stack/virt/network/network-environment.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/noop-deploy-steps.yaml 2>&1
...
2018-03-07 16:31:30Z [overcloud-RedisVirtualIP-annowcpgn5n6]: UPDATE_COMPLETE Stack UPDATE completed successfully
2018-03-07 16:31:30Z [StorageMgmtVirtualIP]: UPDATE_COMPLETE state changed
2018-03-07 16:31:30Z [RedisVirtualIP]: UPDATE_COMPLETE state changed
2018-03-07 16:31:30Z [StorageVirtualIP]: UPDATE_COMPLETE state changed
2018-03-07 16:31:31Z [overcloud-InternalApiVirtualIP-wzb3kkkmdybn]: UPDATE_COMPLETE Stack UPDATE completed successfully
2018-03-07 16:31:31Z [PublicVirtualIP]: UPDATE_COMPLETE state changed
2018-03-07 16:31:31Z [InternalApiVirtualIP]: UPDATE_COMPLETE state changed
2018-03-07 16:31:33Z [VipMap]: UPDATE_IN_PROGRESS state changed
2018-03-07 16:31:33Z [overcloud-VipMap-fh3pw7ax3cls]: UPDATE_IN_PROGRESS Stack UPDATE started
2018-03-07 16:31:34Z [overcloud-VipMap-fh3pw7ax3cls]: UPDATE_COMPLETE Stack UPDATE completed successfully
2018-03-07 16:31:34Z [VipMap]: UPDATE_COMPLETE state changed
2018-03-07 16:31:35Z [EndpointMap]: UPDATE_IN_PROGRESS state changed
2018-03-07 16:31:37Z [EndpointMap]: UPDATE_COMPLETE state changed
2018-03-07 16:31:37Z [overcloud]: UPDATE_FAILED Error in EndpointMap output endpoint_map: Invalid URL port "" for make_url called with {u'host': u'', u'scheme': '', u'port': ''}

 Stack overcloud/efc0b631-450a-4aed-a755-21adf6e7ff06 UPDATE_FAILED

Steps to Reproduce:
1. Upgrade uc to RHOS-13
2. Install tripleoclient from sources:
   sudo yum remove -y python-tripleoclient
   git clone https://github.com/openstack/python-tripleoclient.git
   pushd ~/python-tripleoclient

   # all current/known patches merged on master currently

    sudo rm -rf /usr/lib/python2.7/site-packages/python_tripleoclient*
    sudo rm -rf /usr/lib/python2.7/site-packages/tripleoclient
    sudo python setup.py install
    popd
3. Install tripleocommon from source
    git clone https://github.com/openstack/tripleo-common
    pushd ~/tripleo-common
    sudo python setup.py install
    popd
4. Run `openstack overcloud upgrade prepare ...` command

[Alex Schultz (alex-schultz)]

I don't think we support installing the client from source like that.

[Yurii Prokulevych (yprokule)]

Totally agree with U wrt to support but upgrade workflow has changed a lot and to get early feedback have to install it from source.