DPDK: Deployment failing with ComputeOvsDpdk role when no deprecated parameters present

[Saravanan KR]

Attribute uses_deprecated_params of ComputeOvsDpdk role has been enabled when nic config's has been converted as jinja2 templates for adding deprecated_nic_config_name attribute. But deprecated_nic_config_name is not a parameter deprecation but a nic config file name deprecation, for which uses_deprecated_params should not be enabled.

Enabling this attribute without any deprecated parameters from roles data, results in computeovsdpdk-role file as:
----------------------------------------------------
parameter_groups:
- label: deprecated
  description: Do not use deprecated params, they will be removed.
  parameters:
----------------------------------------------------

Heat will fail if the parameters list is empty for parameter_groups.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/551110

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/551110
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2278c7646b04995ccb961ee70bc9c0c1d7a2f8ac
Submitter: Zuul
Branch: master

commit 2278c7646b04995ccb961ee70bc9c0c1d7a2f8ac
Author: Saravanan KR <email address hidden>
Date: Thu Mar 8 22:03:30 2018 +0530

    DPDK deployment fails when there is no deprecated parameters

    When no deprecated parameters in role_data and enabling flag
    'uses_deprecated_params', deployment fails as the parameter_groups
    has no parameters added to computeovsdpdk-role file. As there are
    no deprecated parameters for this role, this flag should be disabled.
    Closes-Bug: #1754546

    Change-Id: I95c7683b56c82c2cd8d67863867ed8a4f617d1f0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/552304

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552304
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9b1a10bd5a6ec68a26078e939c5c632f67b2eaba
Submitter: Zuul
Branch: stable/queens

commit 9b1a10bd5a6ec68a26078e939c5c632f67b2eaba
Author: Saravanan KR <email address hidden>
Date: Thu Mar 8 22:03:30 2018 +0530

    DPDK deployment fails when there is no deprecated parameters

    When no deprecated parameters in role_data and enabling flag
    'uses_deprecated_params', deployment fails as the parameter_groups
    has no parameters added to computeovsdpdk-role file. As there are
    no deprecated parameters for this role, this flag should be disabled.
    Closes-Bug: #1754546

    Change-Id: I95c7683b56c82c2cd8d67863867ed8a4f617d1f0
    (cherry picked from commit 2278c7646b04995ccb961ee70bc9c0c1d7a2f8ac)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b2 development milestone.