If the "action" parameter is used for "openstack overcloud generate fencing" with recent versions of Pacemaker, the following error occurs during deployment:
overcloud.AllNodesDeploySteps.ControllerDeployment_Step5.2:
resource_type: OS::Heat::StructuredDeployment
physical_resource_id: dde00cd2-8e51-4a4d-9c79-8c9f1e5a95a9
status: CREATE_FAILED
status_reason: |
Error: resources[2]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 2
deploy_stdout: |
...
" with Stdlib::Compat::Hash. There is further documentation for validate_legacy function in the README. at [\"/etc/puppet/modules/ssh/manifests/server.pp\", 12]:[\"/var/lib/tripleo-config/puppet_step_config.pp\", 41]",
"Error: pcs -f /var/lib/pacemaker/cib/puppet-cib-backup20180303-300443-1fhpyxd create failed: Error: stonith option 'action' is deprecated and should not be used, use pcmk_off_action, pcmk_reboot_action instead, use --force to override",
"Error: /Stage[main]/Tripleo::Fencing/Pacemaker::Stonith::Fence_ipmilan[52:54:00:c3:de:fd]/Pcmk_stonith[stonith-fence_ipmilan-525400c3defd]/ensure: change from absent to present failed: pcs -f /var/lib/pacemaker/cib/puppet-cib-backup20180303-300443-1fhpyxd create failed: Error: stonith option 'action' is deprecated and should not be used, use pcmk_off_action, pcmk_reboot_action instead, use --force to override"
]
}
tl;dr it was a mistake (of mine) to ever add this parameter (it doesn't do what I thought it did, and it makes the cluster unstable), and it should be immediately deprecated and no-op'ed.
Fix proposed to branch: master
Review: https:/