GUI state is not updated in case when zaqar message does not arrive

Bug #1753474 reported by Jiri Tomasek on 2018-03-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Undecided
Jiri Tomasek

Bug Description

Currently there is no fallback in case when Zaqar message does not arrive to inform about the status of ongoing Mistral workflow. This leads to cases when user is forced to refresh the page to get to the result of an action.

Tags: ui Edit Tag help

Fix proposed to branch: master
Review: https://review.openstack.org/549751

Changed in tripleo:
status: Triaged → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/550086

Fix proposed to branch: master
Review: https://review.openstack.org/550232

Fix proposed to branch: master
Review: https://review.openstack.org/552532

Changed in tripleo:
assignee: Jiri Tomasek (jtomasek) → Honza Pokorny (hpokorny)

Fix proposed to branch: master
Review: https://review.openstack.org/552545

Fix proposed to branch: master
Review: https://review.openstack.org/552638

Changed in tripleo:
assignee: Honza Pokorny (hpokorny) → Jiri Tomasek (jtomasek)

Reviewed: https://review.openstack.org/549751
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=494af34c9ba6e15318f47db9f006ab1e1bfa7a8a
Submitter: Zuul
Branch: master

commit 494af34c9ba6e15318f47db9f006ab1e1bfa7a8a
Author: Jiri Tomasek <email address hidden>
Date: Fri Mar 2 14:52:59 2018 +0000

    Make running workflows more robust

    Currently there is no fallback in case when Zaqar message does not
    arrive to inform about the status of ongoing Mistral workflow.

    This change introduces mechanism to make execution of workflows more
    robust in TripleO UI:

    Workflows should be triggered using startWorkflow action - startWorkflow
    starts polling for workflow execution after a timeout expires and polls
    until workflow execution is finished. Then it executes a callback (usually
    action dispatch)

    In case a relevant Zaqar message arrives, handleMessage action is triggered
    which cancels the timeout, fetches the execution and passes it to callback.

    Benefits:
    * Application always gets to the result of a workflow execution, regardless
      whether the Zaqar message arrives or not
    * Application does not depend on Zaqar message containing relevant data.
      Message is only required to deliver the execution ID, which is then used
      to fetch execution separately
    * All executions are tracked in application state

    Partial-Bug: #1753474
    Change-Id: I2ae26986e5c2e8870238a287fbd3df46a92ed65f

Reviewed: https://review.openstack.org/550086
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=6e55c9f0a549e533a5e470120f58c78b73dc70b0
Submitter: Zuul
Branch: master

commit 6e55c9f0a549e533a5e470120f58c78b73dc70b0
Author: Jiri Tomasek <email address hidden>
Date: Tue Mar 6 14:55:38 2018 +0100

    Make Validation actions use startWorkflow

    This patch makes runValidation use startWorkflow wrapper to properly
    handle it's execution. This change makes handling validations much
    simpler as there is no specific onFinished callback needed as validations
    only operate on incoming workflow executions which is handled by
    WorkflowActions by default.

    To properly distinguish between start validation and finished validation
    messages (which use the same type) additional logic to zaqar action
    was added.

    runValidationGroups action remains the same as we handle validations
    individually

    Partial-Bug: #1753474
    Change-Id: Ie0f2f1c5175ca8b87fe7ed672548bc9c59865ae0

Reviewed: https://review.openstack.org/550232
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=06b40b3ca36c92d9630378610d5f0404ede6c915
Submitter: Zuul
Branch: master

commit 06b40b3ca36c92d9630378610d5f0404ede6c915
Author: Jiri Tomasek <email address hidden>
Date: Tue Mar 6 20:43:23 2018 +0100

    Make Nodes workflow actions use startWorkflow

    Partial-Bug: #1753474
    Change-Id: I346051af4645d941d074b8ac12650e1b84539037

Reviewed: https://review.openstack.org/552532
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=b9dcdaea0203dda17d93935f9425adf1c1ef93e0
Submitter: Zuul
Branch: master

commit b9dcdaea0203dda17d93935f9425adf1c1ef93e0
Author: Honza Pokorny <email address hidden>
Date: Tue Mar 13 11:34:46 2018 -0300

    Refactor RolesActions to use startWorkflow

    Change-Id: I2e48649a0b8fec99d7f96e3215b99e07e7ea155b
    Partial-Bug: #1753474

Reviewed: https://review.openstack.org/552545
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=cbfb4fac9c9e35480913cd4b80a095939665c877
Submitter: Zuul
Branch: master

commit cbfb4fac9c9e35480913cd4b80a095939665c877
Author: Honza Pokorny <email address hidden>
Date: Tue Mar 13 12:07:36 2018 -0300

    Refactor LoggerActions to use startWorkflow

    Change-Id: I088611e3627374a1bd87f7563395fedf12517c08
    Partial-Bug: #1753474

Reviewed: https://review.openstack.org/552638
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=a9778fa6d44abc15ed21341ff4351e76963213db
Submitter: Zuul
Branch: master

commit a9778fa6d44abc15ed21341ff4351e76963213db
Author: Honza Pokorny <email address hidden>
Date: Tue Mar 13 14:41:13 2018 -0300

    Refactor PlansActions to use startWorkflow

    Change-Id: I417e20d00c060ae8c0424e976c520a27d0c92b7b
    Closes-Bug: #1753474

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/tripleo-ui 9.0.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers