overcloud deploy --no-cleanup flag has reversed logic

Bug #1751079 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Invalid
Low
Bogdan Dobrelya

Bug Description

The --no-cleanup parameter for overcloud deploy, applies reversed

Tags: ux
Changed in tripleo:
importance: Undecided → Low
milestone: none → queens-rc1
tags: added: ux
Changed in tripleo:
assignee: nobody → Bogdan Dobrelya (bogdando)
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

The testing shows it's allright

Changed in tripleo:
status: New → Invalid
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

Related patch to improve tests https://review.openstack.org/#/c/547380

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (master)

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/547380
Reason: mocking shutil.rmtree directly seems is breaking

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/547380
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=97f5fdf5ab3332dbc047ff498cf03eddccc5f3db
Submitter: Zuul
Branch: master

commit 97f5fdf5ab3332dbc047ff498cf03eddccc5f3db
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Feb 23 12:26:23 2018 +0100

    Improve unit tests for overcloud deploy cleanup

    Related-Bug: #1751079

    Change-Id: I99c4dda81b4e66195d82a9bfac6d4830261fd2b0
    Signed-off-by: Bogdan Dobrelya <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.