config-download: use RoleData from downloaded files and not inventory values

[James Slagle]

In https://review.openstack.org/#/c/525260/, we moved the creation of various RoleData driven config files to deploy-steps-tasks.yaml, and to consume the values from various role_data_* variables that were set in the inventory.

However, we were already downloading and saving the RoleData to separate files via config download. We should consume from those files instead of the inventory. That has the advantage that one can quickly modify and iterate on the local files, and have those changes applied. That is harder to do when these values are in the inventory, and not possible to do when using dynamic inventory.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/545102

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/545102
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c334ad38d51482512dab1887013a052a76e24f81
Submitter: Zuul
Branch: master

commit c334ad38d51482512dab1887013a052a76e24f81
Author: James Slagle <email address hidden>
Date: Thu Feb 15 14:36:52 2018 -0500

    Consume RoleData config from config download files

    In https://review.openstack.org/#/c/525260/, we moved the creation of
    various RoleData driven config files to deploy-steps-tasks.yaml, and to
    consume the values from various role_data_* variables that were written in
    the inventory (see https://review.openstack.org/#/c/528354/).

    However, we were already downloading and saving the RoleData to separate
    files via config download. We should consume from those files instead of
    the inventory. That has the advantage that one can quickly modify and
    iterate on the local files, and have those changes applied. That is
    harder to do when these values are in the inventory, and not possible to
    do when using dynamic inventory.

    Since the tasks will fail trying to read from the files when not using
    config-download, conditional local_action tasks that use the stat module
    first verify the existence of the files before attempting to read their
    contents. If they don't exist, the values fall back to whatever has been
    defined by the ansible variable.

    Change-Id: Idfdce6f0a778b0a7f2fed17ff56d1a3e451868ab
    Closes-Bug: #1749784

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/561921

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/561921
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e4a85e5682dcf9e75cf7c0e7cbec4c6e9b94310b
Submitter: Zuul
Branch: stable/queens

commit e4a85e5682dcf9e75cf7c0e7cbec4c6e9b94310b
Author: James Slagle <email address hidden>
Date: Thu Feb 15 14:36:52 2018 -0500

    Consume RoleData config from config download files

    In https://review.openstack.org/#/c/525260/, we moved the creation of
    various RoleData driven config files to deploy-steps-tasks.yaml, and to
    consume the values from various role_data_* variables that were written in
    the inventory (see https://review.openstack.org/#/c/528354/).

    However, we were already downloading and saving the RoleData to separate
    files via config download. We should consume from those files instead of
    the inventory. That has the advantage that one can quickly modify and
    iterate on the local files, and have those changes applied. That is
    harder to do when these values are in the inventory, and not possible to
    do when using dynamic inventory.

    Since the tasks will fail trying to read from the files when not using
    config-download, conditional local_action tasks that use the stat module
    first verify the existence of the files before attempting to read their
    contents. If they don't exist, the values fall back to whatever has been
    defined by the ansible variable.

    Change-Id: Idfdce6f0a778b0a7f2fed17ff56d1a3e451868ab
    Closes-Bug: #1749784
    (cherry picked from commit c334ad38d51482512dab1887013a052a76e24f81)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.2 release.