tripleo

Duplicate of horizon::vhost_extra_params in docker/services/horizon.yaml

Bug #1749627 reported by Sai Ram Peesapati on 2018-02-15

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Emilien Macchi	tripleo queens-rc1

Bug Description

There is a parameter called HorizonVhostExtraParams which sets horizon::vhost_extra_params in puppet/services/horizon.yaml.
But, horizon::vhost_extra_params is hardcoded in docker/services/horizon.yaml, which is overwitting the values passed to HorizonVhostExtraParams.

Tags:

Emilien Macchi (emilienm) on 2018-02-15

Changed in tripleo:
milestone:	none → queens-rc1
assignee:	nobody → Emilien Macchi (emilienm)
status:	New → Triaged
importance:	Undecided → High

OpenStack Infra (hudson-openstack) on 2018-02-15

Changed in tripleo:
status:	Triaged → In Progress

Revision history for this message

Emilien Macchi (emilienm) wrote on 2018-02-15:

https://review.openstack.org/#/c/544758/

Bogdan Dobrelya (bogdando) on 2018-02-15

tags:

added: pike-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-02-17: Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/544758
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=995cf7105759689d72b1664726ab02a69fe1864d
Submitter: Zuul
Branch: master

commit 995cf7105759689d72b1664726ab02a69fe1864d
Author: Emilien Macchi <email address hidden>
Date: Wed Feb 14 18:01:29 2018 -0800

docker: don't override horizon::vhost_extra_params

    horizon::vhost_extra_params is already configured in
    puppet/services/horizon.yaml, and users can change the value with
    HorizonVhostExtraParams parameter.

Docker deployments didn't have HorizonVhostExtraParams taken in account
since we were overriding with Hiera. This patch fix it.

Closes-Bug: #1749627
Change-Id: I77f1312112c7f613d795242060709082ef72f150

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-02-17: Fix proposed to tripleo-heat-templates (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/545636

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-02-18: Fix merged to tripleo-heat-templates (stable/pike)

Reviewed: https://review.openstack.org/545636
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=cfa0e21b47e51c1bc15271b1cd34a2a325fc9a21
Submitter: Zuul
Branch: stable/pike

commit cfa0e21b47e51c1bc15271b1cd34a2a325fc9a21
Author: Emilien Macchi <email address hidden>
Date: Wed Feb 14 18:01:29 2018 -0800

docker: don't override horizon::vhost_extra_params

    horizon::vhost_extra_params is already configured in
    puppet/services/horizon.yaml, and users can change the value with
    HorizonVhostExtraParams parameter.

Docker deployments didn't have HorizonVhostExtraParams taken in account
since we were overriding with Hiera. This patch fix it.

    Closes-Bug: #1749627
    Change-Id: I77f1312112c7f613d795242060709082ef72f150
    (cherry picked from commit 995cf7105759689d72b1664726ab02a69fe1864d)