debug ansible tasks aren't named

Bug #1748443 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Steven Hardy

Bug Description

In the deploy steps tasks, we have some bare debug tasks, without any name.

This means you get an output like:

    TASK [Run puppet host configuration for step 1] ********************************
    ok: [localhost]

    TASK [debug] *******************************************************************
    fatal: [localhost]: FAILED! => {
        "changed": false,
        "failed_when_result": true,
        "outputs.stdout_lines|default([])|union(outputs.stderr_lines|default([]))": [
            "Debug: Runtime environment: puppet_version=4.8.2, ruby_version=2.0.0, run_mode=user, default_encoding=UTF-8",
            "Debug: Evicting cache entry for environment 'production'",
            "Debug: Caching environment 'production' (ttl = 0 sec)",
            "Debug: Loading external facts from /etc/puppet/modules/openstacklib/facts.d",
            "Debug: Loading external facts from /var/lib/puppet/facts.d",
...

IMO it would be better to be explicit, as here it looks like the puppet host configuration worked, but it actually failed and triggered the debug output

Steven Hardy (shardy)
Changed in tripleo:
milestone: none → queens-rc1
status: New → Triaged
assignee: nobody → Steven Hardy (shardy)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/542813

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/542813
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7f4811779f003255664c41717535318d3feb0ad5
Submitter: Zuul
Branch: master

commit 7f4811779f003255664c41717535318d3feb0ad5
Author: Steven Hardy <email address hidden>
Date: Fri Feb 9 13:18:49 2018 +0000

    Add name to debug tasks

    This makes it clearer that the previous task failed, which isn't
    immediately evident from the ansible task output due to the failed_when
    on those tasks.

    Change-Id: I765208d5865f6e5a292e5b52c572e2e79540c663
    Closes-Bug: #1748443

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.0.0.0rc1

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.