tripleo

Redundant action keys on NetworkDeployment

Bug #1747072 reported by James Slagle on 2018-02-02

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Medium	James Slagle	tripleo queens-rc1

Bug Description

There are two "action:" keys on NetworkDeployment in role.role.j2.yaml. The last one seems to win, which is what we want, but the first still should be removed for clarity.

Tags:

James Slagle (james-slagle) on 2018-02-02

Changed in tripleo:
status:	New → In Progress
importance:	Undecided → Medium
assignee:	nobody → James Slagle (james-slagle)
milestone:	none → queens-rc1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-02-02: Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/540504

Revision history for this message

James Slagle (james-slagle) wrote on 2018-02-02:

https://review.openstack.org/540504

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-02-05: Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/540504
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e727fd416975fb2a94efe6321f71fcbe1ee0ad43
Submitter: Zuul
Branch: master

commit e727fd416975fb2a94efe6321f71fcbe1ee0ad43
Author: James Slagle <email address hidden>
Date: Fri Feb 2 15:08:07 2018 -0500

Remove redundant action key on NetworkDeployment

action was specified twice on NetworkDeployment. The first occurrence is
just ignored by Heat, so remove it for clarity.

Change-Id: Iff24a65c09f37f2777787e7436f7902f5e6a122f
Closes-Bug: #1747072

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-02-12: Fix proposed to tripleo-heat-templates (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/543562

James Slagle (james-slagle) on 2018-02-12

tags:

added: pike-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-03-03: Fix included in openstack/tripleo-heat-templates 8.0.0.0rc1

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-03-08: Fix merged to tripleo-heat-templates (stable/pike)

Reviewed: https://review.openstack.org/543562
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=96aa7fd0897471c4f17f335cdff90171623eb2d1
Submitter: Zuul
Branch: stable/pike

commit 96aa7fd0897471c4f17f335cdff90171623eb2d1
Author: James Slagle <email address hidden>
Date: Fri Feb 2 15:08:07 2018 -0500

Remove redundant action key on NetworkDeployment

action was specified twice on NetworkDeployment. The first occurrence is
just ignored by Heat, so remove it for clarity.

    Change-Id: Iff24a65c09f37f2777787e7436f7902f5e6a122f
    Closes-Bug: #1747072
    (cherry picked from commit e727fd416975fb2a94efe6321f71fcbe1ee0ad43)