RabbitMQ user name not set in Neutron transport_url

[Matt Wisch]

When deploying an overcloud stack with the Pike Tripleo Heat Templates, and overriding the default RabbitMQ admin user with the "RabbitUserName" parameter, Neutron will not be configured with a correct transport_url defaulting to the guest user which does not exist.

DEFAULT/rabbitmq_userid will be set correctly, but this is depricated and will be overriden by the transport_url setting.

The issue is an incorrect parameter mapping in puppet-tripleo, tripleo::profile::base::neutron:

  $oslomsg_rpc_username = hiera('neutron::rabbit_userid', 'guest')

https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/neutron.pp#L88

Unlike the other services that user rabbit_userid, Neutron maps this parameter to neutron::rabbit_user

https://github.com/openstack/tripleo-heat-templates/blob/stable/pike/puppet/services/neutron-base.yaml#L127

openstack-tripleo-heat-templates-7.0.3-18.el7ost.noarch
puppet-tripleo-7.4.3-11.el7ost.noarch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/538966

[Brent Eagles (beagles)]

Bug shouldn't have been set to "Fix Committed" until it's been merged.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/538966
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=49be755b2cfc80753a808375c5f6584c3db4987b
Submitter: Zuul
Branch: master

commit 49be755b2cfc80753a808375c5f6584c3db4987b
Author: Matt Wisch <email address hidden>
Date: Mon Jan 29 09:44:41 2018 -0700

    Correct Neutron RabbitMQ User Param Mapping

    Changed parameter mapping for RabbitMQ user name
    overrides. THT maps the user name override to
    neutron::rabbit_user for the Neutron service only.

    This will allow the transport_url string to be built
    correctly when a deployer wishes to override the default
    guest username.

    Change-Id: I0e35a6979765a453e2ed219e6026f6c0a17b2013
    Closes-Bug: 1746034

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/550439

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/550440

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550440
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=e1bd1290f5a014cd73815de7e06b59fee82847c3
Submitter: Zuul
Branch: stable/pike

commit e1bd1290f5a014cd73815de7e06b59fee82847c3
Author: Matt Wisch <email address hidden>
Date: Mon Jan 29 09:44:41 2018 -0700

    Correct Neutron RabbitMQ User Param Mapping

    Changed parameter mapping for RabbitMQ user name
    overrides. THT maps the user name override to
    neutron::rabbit_user for the Neutron service only.

    This will allow the transport_url string to be built
    correctly when a deployer wishes to override the default
    guest username.

    Change-Id: I0e35a6979765a453e2ed219e6026f6c0a17b2013
    Closes-Bug: 1746034
    (cherry picked from commit 49be755b2cfc80753a808375c5f6584c3db4987b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550439
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=bce78ef54a3d85e192766b391b695b237c2263eb
Submitter: Zuul
Branch: stable/queens

commit bce78ef54a3d85e192766b391b695b237c2263eb
Author: Matt Wisch <email address hidden>
Date: Mon Jan 29 09:44:41 2018 -0700

    Correct Neutron RabbitMQ User Param Mapping

    Changed parameter mapping for RabbitMQ user name
    overrides. THT maps the user name override to
    neutron::rabbit_user for the Neutron service only.

    This will allow the transport_url string to be built
    correctly when a deployer wishes to override the default
    guest username.

    Change-Id: I0e35a6979765a453e2ed219e6026f6c0a17b2013
    Closes-Bug: 1746034
    (cherry picked from commit 49be755b2cfc80753a808375c5f6584c3db4987b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 7.4.11 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.0.0 release.