Parameters form does not load for environments with large amount of parameters

Bug #1745408 reported by Jiri Tomasek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Jiri Tomasek

Bug Description

Formsy-react forms do not perform well with React 16, large forms need to get moved to using redux-form

Tags: ui
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/539192

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/539192
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=0e7d65228a29182e899569e4750d39f116c947e9
Submitter: Zuul
Branch: master

commit 0e7d65228a29182e899569e4750d39f116c947e9
Author: Jiri Tomasek <email address hidden>
Date: Fri Jan 19 11:46:25 2018 +0100

    Convert Parameters form to use redux-form

    Using Formsy in large forms causes performance problems

    * Introduce ParametersForm and ParametersSidebar
    * Add NewParameterInputList and NewParameterInput as the old ones are
      still used in role forms. After those are converted too, we'll rename
      these components
    * Validate json parameter inputs
    * Handle submitting of ParametersForm
    * Separate updateParameters action to 3 actions: updateParameters,
      updateNodesAssignment, updateRoleParameters as those 3 dialogs all
      update parameters using the same mistral action but they handle it
      differently

    Implements: blueprint ui-redux-form-migration
    Closes-Bug: 1745408
    Change-Id: I527f3587f8adce89be649c487d9a0df5ce4939d5

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/544000

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/544000
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=d87861e059be12a9fb0b9b25029cb9b7371306b4
Submitter: Zuul
Branch: master

commit d87861e059be12a9fb0b9b25029cb9b7371306b4
Author: Jiri Tomasek <email address hidden>
Date: Tue Feb 13 09:54:51 2018 +0100

    Convert Role detail dialog to redux-form

    * As parameters are configured in multiple places this change makes
      ParametersForm reusable by moving functions for gathering initial
      values and preparing values for submitting into ParametersForm. To achieve
      that, ParametersForm has to be connected to Redux
    * ParametersForm can now be reused and the set of parameters it operates
      on is defined by passing fields as children prop
    * ParametersForm can eventually be further parameterized as it currently
      only works for ModalPanels
    * RoleDetail dialog has been converted to use ParametersForm and
      therefore it got converted to redux-form
    * RoleDetail dialog now has Save and close submit button
    * RoleDetail dialog now persists data when switching between individual
      dialog tabs

    Closes-Bug: 1745408
    Implements: blueprint ui-redux-form-migration
    Change-Id: I302c24b4cb4e94230c213305a536fa9e6ad09296

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ui 8.3.0

This issue was fixed in the openstack/tripleo-ui 8.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.