`overcloud update stack` doesn't use --templates argument

[Julie Pichon]

I was looking into a old bug about templates not updating in the Swift plan when running stack updates, which I believe was mostly fixed in Pike thanks to bug 1715557 / https://review.openstack.org/#/c/487496/ . However it seems the templates will only be updated from the default location in /usr/share/ because the --templates argument isn't actually used.

It is present: https://github.com/openstack/python-tripleoclient/blob/4ed12d/tripleoclient/v1/overcloud_update.py#L45 but doesn't seem to be called anywhere. When calling the workflow that will update the plan, it is not passed along:

https://github.com/openstack/python-tripleoclient/blob/4ed12d/tripleoclient/v1/overcloud_update.py#L119

so in the end the action always updates the plan with the templates from the default location:

https://github.com/openstack/tripleo-common/blob/117bac/workbooks/package_update.yaml#L9-L30
https://github.com/openstack/tripleo-common/blob/117bac/tripleo_common/actions/plan.py#L209-L221

Looking more closely at tripleo.package_update.v1.package_update_plan it looks like the workflow may need to be updated first to allow setting the templates path? (The plan action itself already takes in a templates_dir argument.)

Version: current master

[Jiří Stránský (jistr)]

Sorry, i didn't see this when reporting the other one.

[Julie Pichon (jpichon)]

No problems, the description in the new one is clearer and more to the point!