The step_config in role_data breaks the ansible inventory

Bug #1744003 reported by mathieu bultel
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Jiří Stránský

Bug Description

Since we added the role_data in the ansible inventory, the step_config (role_data_step_config) is breaking the syntax:
inventory:
role_data_step_config = include ::tripleo::trusted_cas
        include ::tripleo::profile::base::cinder::api

        include ::tripleo::profile::base::cinder::scheduler

        include ::tripleo::profile::base::cinder::volume

        include ::tripleo::profile::base::docker

        include ::tripleo::profile::base::keepalived

        include ::tripleo::profile::base::kernel
        include ::tripleo::profile::base::database::mysql::client
        include ::tripleo::profile::base::time::ntp
        include ::tripleo::profile::base::snmp

        include ::tripleo::profile::base::sshd

which cause:
 [WARNING]: * Failed to parse /home/stack/hooooo with ini plugin: /home/stack/hooooo:53: Expected key=value, got: include
::tripleo::profile::base::cinder::api
PLAY [overcloud] ***************************************************************************************************************************************
skipping: no hosts matched

Changed in tripleo:
status: New → In Progress
Changed in tripleo:
importance: Undecided → High
Revision history for this message
mathieu bultel (mat-bultel) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/536836

Changed in tripleo:
assignee: mathieu bultel (mat-bultel) → Jiří Stránský (jistr)
Revision history for this message
Jiří Stránský (jistr) wrote :

We should use the YAML inventory which can handle multiline strings, e.g. https://review.openstack.org/534844/

Revision history for this message
Jiří Stránský (jistr) wrote :

Sorry i meant to link this: https://review.openstack.org/#/c/536836/

Revision history for this message
Jiří Stránský (jistr) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/536836
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=4ed12dac803924a4420c5d4da5a926f2867dae4f
Submitter: Zuul
Branch: master

commit 4ed12dac803924a4420c5d4da5a926f2867dae4f
Author: Jiri Stransky <email address hidden>
Date: Tue Jan 23 14:53:33 2018 +0100

    Use YAML inventory for minor update

    This makes sure we can correctly handle multiline strings. The
    previous ini format was quite limited in what it could handle, and
    multiline strings broke it.

    Change-Id: I9ee83f81eaf49b16fb4002bf8d7a3ecb4fe1553d
    Closes-Bug: #1744003

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 9.1.0

This issue was fixed in the openstack/python-tripleoclient 9.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (master)

Change abandoned by mathieu bultel (<email address hidden>) on branch: master
Review: https://review.openstack.org/534844

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.