composable service resource registry parameters make workflow to fail

[Michael Henkel]

Description
===========

In case a custom role needs a custom service, the resource_registry is defined in an environment file which is added to the cli:
e.g. role:
  ServicesDefault:
    - OS::TripleO::Services::ContrailWebui

environment file:
resource_registry:
  OS::TripleO::Services::ContrailWebui: ../../docker/services/contrail/contrail-webui.yaml

Creating a stack fails because tripleo cannot find the resource registry for the service, even though it is defined in the environment file and the file is added with -e to the openstack overcloud deploy command.

Steps to reproduce
==================

Create a stack with a custom role and service

Environment
===========

tripleo-dev

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/534337

[Steven Hardy (shardy)]

Note the root cause of this is https://review.openstack.org/#/c/511249/ which recently merged, which means we validate the templates when updating the parameters, which previously was not the case.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/534337
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=7c0ad1df5e49358299cea3cd15ccdd6d2c54271d
Submitter: Zuul
Branch: master

commit 7c0ad1df5e49358299cea3cd15ccdd6d2c54271d
Author: Michael Henkel <email address hidden>
Date: Tue Jan 16 15:50:35 2018 +0100

    Composable role and service fails workflow

    When defining a resource_registry for a composable service, the workflow fails
    because it validates before the user-environment is added.
    This patch moves the workflow invocation after the creation of the user-
    environment.
    This is caused by https://review.openstack.org/#/c/511249/ which changes the
    behaviour of the action in tripleo-common.

    Change-Id: Idf17e3f817708d9e7dd7241063434ce56b6be052
    Closes-Bug: 1743575

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/542890

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/542890
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=e4d440af2f8511574735cc6d04675747e4e06867
Submitter: Zuul
Branch: stable/pike

commit e4d440af2f8511574735cc6d04675747e4e06867
Author: Michael Henkel <email address hidden>
Date: Tue Jan 16 15:50:35 2018 +0100

    Composable role and service fails workflow

    When defining a resource_registry for a composable service, the workflow fails
    because it validates before the user-environment is added.
    This patch moves the workflow invocation after the creation of the user-
    environment.
    This is caused by https://review.openstack.org/#/c/511249/ which changes the
    behaviour of the action in tripleo-common.

    Change-Id: Idf17e3f817708d9e7dd7241063434ce56b6be052
    Closes-Bug: 1743575
    (cherry picked from commit 7c0ad1df5e49358299cea3cd15ccdd6d2c54271d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 7.3.9 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.0.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/564692

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/564692
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=0b1565d88c1d3dc2ca3f718bb3f40dbb5ef8ad5a
Submitter: Zuul
Branch: stable/queens

commit 0b1565d88c1d3dc2ca3f718bb3f40dbb5ef8ad5a
Author: Michael Henkel <email address hidden>
Date: Tue Jan 16 15:50:35 2018 +0100

    Composable role and service fails workflow

    When defining a resource_registry for a composable service, the workflow fails
    because it validates before the user-environment is added.
    This patch moves the workflow invocation after the creation of the user-
    environment.
    This is caused by https://review.openstack.org/#/c/511249/ which changes the
    behaviour of the action in tripleo-common.

    Change-Id: Idf17e3f817708d9e7dd7241063434ce56b6be052
    Closes-Bug: 1743575
    (cherry picked from commit 7c0ad1df5e49358299cea3cd15ccdd6d2c54271d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 9.2.2 release.