quickstart reproducer create script is getting skipped

[wes hayutin]

According to the publish.yml task [1] the reproducer script should be created when ever toci_jobtype is not empty.

This seems to be skipping.

http://logs.openstack.org/50/524250/4/check-tripleo/tripleo-ci-centos-7-ovb-ha-oooq/9d85d71/logs/quickstart_collect_logs.log

TASK [collect-logs : Create the reproducer script] *****************************
task path: /home/zuul/workspace/.quickstart/usr/local/share/ansible/roles/collect-logs/tasks/publish.yml:63
Wednesday 10 January 2018 20:56:10 +0000 (0:00:00.093) 0:05:31.195 *****
skipping: [undercloud] => {"changed": false, "skip_reason": "Conditional result was False", "skipped": true}

http://logs.openstack.org/02/510902/26/check/tripleo-ci-centos-7-scenario001-multinode-oooq-container/d5f7ecb/logs/quickstart_collect_logs.log

TASK [collect-logs : Create the reproducer script] *****************************
task path: /home/zuul/workspace/.quickstart/usr/local/share/ansible/roles/collect-logs/tasks/publish.yml:63
Wednesday 10 January 2018 17:04:50 +0000 (0:00:00.115) 0:10:48.611 *****
skipping: [undercloud] => {"changed": false, "skip_reason": "Conditional result was False", "skipped": true}
skipping: [subnode-2] => {"changed": false, "skip_reason": "Conditional result was False", "skipped": true}

[1] https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/collect-logs/tasks/publish.yml#L63-L66

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/532650

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/532650
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=8b39e49059af6035781a93ecb20faeec7c7ebefe
Submitter: Zuul
Branch: master

commit 8b39e49059af6035781a93ecb20faeec7c7ebefe
Author: Wes Hayutin <email address hidden>
Date: Wed Jan 10 17:19:40 2018 -0500

    fix reproducer script when statement

    Using var/log/extra/dump_variables_hostvars.json.txt.gz
    We can see the existance of this variable in the logs.

    closes-Bug: #1742557
    Change-Id: Ifd02ab371731dd4be863c193878567d170b02ee7

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.