kernel: missing interface to easily customize settings / modules

Bug #1742440 reported by Emilien Macchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Emilien Macchi

Bug Description

The list of kernel modules and sysctl settings is hardcoded in kernel composable service in TripleO Heat Templates. They can be overridden via Hiera but if you go down that path, operator has to maintain the previous list of default parameters.

One option would be to give 2 parameters so the operators could give an extra dictionary of settings / modules that would merge with the default.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/532529

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/532529
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ec1be1f4cdb605ed70fde1b4b1f8e551319629bd
Submitter: Zuul
Branch: master

commit ec1be1f4cdb605ed70fde1b4b1f8e551319629bd
Author: Emilien Macchi <email address hidden>
Date: Wed Jan 10 05:35:34 2018 -0800

    kernel: allow to override modules & sysctl settings

    Allow to easily personalize Kernel modules and sysctl settings with two new parameters.
    ExtraKernelModules and ExtraSysctlSettings are dictionaries that will take precedence
    over the defaults settings provided in the composable service.

    Closes-Bug: #1742440
    Change-Id: I9cd43331e5e9a6074cd47040c29815ca32c61693

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/532734

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/532735

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/532736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/pike)

Reviewed: https://review.openstack.org/532734
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=65b642a252f6467f351a75ee2d3aeb1094305fb6
Submitter: Zuul
Branch: stable/pike

commit 65b642a252f6467f351a75ee2d3aeb1094305fb6
Author: Emilien Macchi <email address hidden>
Date: Wed Jan 10 05:35:34 2018 -0800

    kernel: allow to override modules & sysctl settings

    Allow to easily personalize Kernel modules and sysctl settings with two new parameters.
    ExtraKernelModules and ExtraSysctlSettings are dictionaries that will take precedence
    over the defaults settings provided in the composable service.

    Closes-Bug: #1742440
    Change-Id: I9cd43331e5e9a6074cd47040c29815ca32c61693
    (cherry picked from commit ec1be1f4cdb605ed70fde1b4b1f8e551319629bd)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/ocata)

Reviewed: https://review.openstack.org/532735
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e9e0206bb4e8f20420a928b77e417c9da9b8ffa5
Submitter: Zuul
Branch: stable/ocata

commit e9e0206bb4e8f20420a928b77e417c9da9b8ffa5
Author: Emilien Macchi <email address hidden>
Date: Wed Jan 10 05:35:34 2018 -0800

    kernel: allow to override modules & sysctl settings

    Allow to easily personalize Kernel modules and sysctl settings with two new parameters.
    ExtraKernelModules and ExtraSysctlSettings are dictionaries that will take precedence
    over the defaults settings provided in the composable service.

    Closes-Bug: #1742440
    Change-Id: I9cd43331e5e9a6074cd47040c29815ca32c61693
    (cherry picked from commit ec1be1f4cdb605ed70fde1b4b1f8e551319629bd)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/newton)

Reviewed: https://review.openstack.org/532736
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=04dad02d73fa5fee5ae7994349381250b4d5ae6a
Submitter: Zuul
Branch: stable/newton

commit 04dad02d73fa5fee5ae7994349381250b4d5ae6a
Author: Emilien Macchi <email address hidden>
Date: Wed Jan 10 05:35:34 2018 -0800

    kernel: allow to override modules & sysctl settings

    Allow to easily personalize Kernel modules and sysctl settings with two new parameters.
    ExtraKernelModules and ExtraSysctlSettings are dictionaries that will take precedence
    over the defaults settings provided in the composable service.

    Closes-Bug: #1742440
    Change-Id: I9cd43331e5e9a6074cd47040c29815ca32c61693
    (cherry picked from commit ec1be1f4cdb605ed70fde1b4b1f8e551319629bd)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 5.3.9

This issue was fixed in the openstack/tripleo-heat-templates 5.3.9 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 7.0.8

This issue was fixed in the openstack/tripleo-heat-templates 7.0.8 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 6.2.9

This issue was fixed in the openstack/tripleo-heat-templates 6.2.9 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.0.0.0b3

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.