ControllerNoCeph does not configure a CephClient for controller services that need it, e.g. Cinder, Glance, etc

[John Fulton]

When using deploying an overcloud with the roles introduced by https://review.openstack.org/#/c/521989 with the following:

openstack overcloud roles generate \
   --roles-path ~/templates/roles \
   --output-file ~/roles_data.yaml \
   ControllerNoCeph HciCephAll Compute

The overcloud completes but Glance is unable to upload images [1] and Cinder is unable to create volumes [2].

This seems to be because the new ControllerNoCeph role is missing the CephClient service. This service was not in the Controller role in the past because it had a CephMon service which configured the settings required for a Ceph client, but when the CephMon service was removed for this new role the CephClient service should have been added in its place.

[1]

Importing cirros-0.3.4-x86_64-disk.raw image into Glance
500 Internal Server Error: The server has either erred or is incapable of performing the requested operation. (HTTP 500)
Could not import cirros-0.3.4-x86_64-disk.raw image. Aborting

[2]
+---------------------+--------------------------------------+
| Field | Value |
+---------------------+--------------------------------------+
| attachments | [] |
| availability_zone | nova |
| bootable | false |
| consistencygroup_id | None |
| created_at | 2018-01-04T15:29:33.000000 |
| description | None |
| encrypted | False |
| id | 1f49b544-11c3-4118-8e39-795fda774514 |
| migration_status | None |
| multiattach | False |
| name | test-volume |
| properties | |
| replication_status | None |
| size | 1 |
| snapshot_id | None |
| source_volid | None |
| status | creating |
| type | None |
| updated_at | None |
| user_id | 92822d079568412e94b8a3d6b983f035 |
+---------------------+--------------------------------------+
+--------------------------------------+-------------+--------+------+-------------+
| ID | Name | Status | Size | Attached to |
+--------------------------------------+-------------+--------+------+-------------+
| 1f49b544-11c3-4118-8e39-795fda774514 | test-volume | error | 1 | |
+--------------------------------------+-------------+--------+------+-------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/531163

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531163
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a85718428a732697b8b3ab0029dd38cdc94dc012
Submitter: Zuul
Branch: master

commit a85718428a732697b8b3ab0029dd38cdc94dc012
Author: John Fulton <email address hidden>
Date: Thu Jan 4 09:44:44 2018 -0500

    Add missing CephClient service to ControllerNoCeph role

    Change-Id: Ice5b52c1cedaf5662ea9a9058ba155c3e9d84258
    Closes-Bug: #1741270

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b3 development milestone.