n->o->p major-upgrade-composable-steps-docker.yaml fails with Error: Evaluation Error: Error while evaluating a Function Call, Could not find class ::panko

[Sofer Athlan-Guyot]

Originally reported there https://bugzilla.redhat.com/show_bug.cgi?id=1523272

Basically during the last upgrade we fail:

major-upgrade-composable-steps-docker.yaml fails with Error: Evaluation Error: Error while evaluating a Function Call, Could not find class ::panko because the /etc/puppet/modules/panko symlink is missing:

We can see 2 docker-puppet containers failures caused by this:
[root@controller-0 ~]# docker logs --tail 5 docker-puppet-panko
Error: Evaluation Error: Error while evaluating a Function Call, Could not find class ::panko for controller-0.localdomain at /etc/puppet/modules/tripleo/manifests/profile/base/panko.pp:31:5 on node controller-0.localdomain
+ rc=1
+ set -e
+ '[' 1 -ne 2 -a 1 -ne 0 ']'
+ exit 1
[root@controller-0 ~]# docker logs --tail 5 docker-puppet-mysql
Error: Evaluation Error: Error while evaluating a Function Call, Could not find class ::panko::db::mysql for controller-0.localdomain at /etc/puppet/modules/tripleo/manifests/profile/base/database/mysql.pp:227:7 on node controller-0.localdomain
+ rc=1
+ set -e
+ '[' 1 -ne 2 -a 1 -ne 0 ']'
+ exit 1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/526440

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/526473

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/526440
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=4a708af34afb827ee067baf2f8eb3c4285aa26d7
Submitter: Zuul
Branch: master

commit 4a708af34afb827ee067baf2f8eb3c4285aa26d7
Author: Sofer Athlan-Guyot <email address hidden>
Date: Thu Dec 7 16:50:54 2017 +0100

    Add modulepath option when applying puppet inside docker.

    When new module are added, we may miss the symlink in
    /etc/puppet/modules. And for consistency as we mount the
    /usr/share/openstack-puppet/modules directory it’s better to add it
    to the modulepath.

    Change-Id: I963aede41403ebbe3b9afb55a725b304a30a0cbb
    Closes-Bug: #1736980

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/526473
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=254140071756fae1f5502c7837b6cf3e12682acb
Submitter: Zuul
Branch: stable/pike

commit 254140071756fae1f5502c7837b6cf3e12682acb
Author: Sofer Athlan-Guyot <email address hidden>
Date: Thu Dec 7 16:50:54 2017 +0100

    Add modulepath option when applying puppet inside docker.

    When new module are added, we may miss the symlink in
    /etc/puppet/modules. And for consistency as we mount the
    /usr/share/openstack-puppet/modules directory it’s better to add it
    to the modulepath.

    Change-Id: I963aede41403ebbe3b9afb55a725b304a30a0cbb
    Closes-Bug: #1736980
    (cherry picked from commit 4a708af34afb827ee067baf2f8eb3c4285aa26d7)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b3 development milestone.