ExtraConfigPre ignored by ceph-ansible

[Giulio Fidente]

Use of $roleExtraConfigPre to pass node specific data is not supported by the mistral workflow triggering mechanism

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/526030

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/526073

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/528283

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/528376

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/528376
Committed: https://git.openstack.org/cgit/openstack/tripleo-docs/commit/?id=7bcc6e86f1fc1732b073a301d8fe0f6a4de0f642
Submitter: Zuul
Branch: master

commit 7bcc6e86f1fc1732b073a301d8fe0f6a4de0f642
Author: John Fulton <email address hidden>
Date: Fri Dec 15 14:27:08 2017 -0500

    Update node-specfic data doc to cover ceph-ansible usage

    Change-Id: I36d752132f36af947dca025915724d9e192ec161
    Related-Bug: #1736707

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/528283
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=9b29951875b4251bf0de578186ab6248daa3afac
Submitter: Zuul
Branch: stable/pike

commit 9b29951875b4251bf0de578186ab6248daa3afac
Author: Giulio Fidente <email address hidden>
Date: Fri Dec 15 15:24:55 2017 +0100

    Add json_parse and yaml_parse mistral expression functions

    This change adds parsing of JSON and YAML as a mistral functions.

    Change-Id: I9970abae47ca355861e37cdb5db0ab24d564b57a
    Related-Bug: #1736707

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/526030
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=eda02c05d7b688d3b81321377bf4b32bfa5329bd
Submitter: Zuul
Branch: master

commit eda02c05d7b688d3b81321377bf4b32bfa5329bd
Author: Giulio Fidente <email address hidden>
Date: Wed Dec 6 12:01:25 2017 +0100

    Consume NodeDataLookup in ceph-ansible

    Makes it possible to provide per-node variables to ceph-ansible
    using the NodeDataLookup parameter, the same consumed by the
    $roleExtraConfigPre resource for puppet hieradata.

    Change-Id: Ia23825aea938f6f9bcf536e35cad562a1b96c93b
    Closes-Bug: #1736707
    Co-Authored-By: <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/526073
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1971e7b049f13a8a2d45fb77412ff1a87ca043c2
Submitter: Zuul
Branch: master

commit 1971e7b049f13a8a2d45fb77412ff1a87ca043c2
Author: Giulio Fidente <email address hidden>
Date: Wed Dec 6 14:53:18 2017 +0100

    Passes NodeDataLookup to ceph-ansible workflow

    Per-node customizations were only dumped as hieradata, so the
    ceph-ansible workflow could not consume them.
    This change passes the structure to the mistral workflow so that it
    can consume the data and populate the inventory accordingly.

    Change-Id: Ie7a9f10f0c821b8c642494a4d3933b2901f39d40
    Depends-On: Ia23825aea938f6f9bcf536e35cad562a1b96c93b
    Closes-Bug: #1736707

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/528755

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/528757

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/528755
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=9bb5fcc5bd34fd138062c646da808921422d0b7a
Submitter: Zuul
Branch: stable/pike

commit 9bb5fcc5bd34fd138062c646da808921422d0b7a
Author: Giulio Fidente <email address hidden>
Date: Wed Dec 6 12:01:25 2017 +0100

    Consume NodeDataLookup in ceph-ansible

    Makes it possible to provide per-node variables to ceph-ansible
    using the NodeDataLookup parameter, the same consumed by the
    $roleExtraConfigPre resource for puppet hieradata.

    Change-Id: Ia23825aea938f6f9bcf536e35cad562a1b96c93b
    Closes-Bug: #1736707
    Co-Authored-By: <email address hidden>
    (cherry picked from commit eda02c05d7b688d3b81321377bf4b32bfa5329bd)

[Gonéri Le Bouder (goneri)]

I manually applied the two backports on the last OSP12 puddle and I use the heat template described in: https://bugzilla.redhat.com/show_bug.cgi?id=1520004#c0

My inventory.yaml does not come with any host specific configuration:

clients:
  hosts:
    192.168.120.114: {}
    192.168.120.116: {}
    192.168.120.118: {}
mdss:
  hosts: {}
mons:
  hosts:
    192.168.120.110: {}
    192.168.120.112: {}
    192.168.120.115: {}
osds:
  hosts:
    192.168.120.109: {}
    192.168.120.117: {}
    192.168.120.119: {}
rgws:
  hosts:
    192.168.120.110: {}
    192.168.120.112: {}
    192.168.120.115: {}
overcloud:
  hosts:
    192.168.120.109: {}
    192.168.120.110: {}
    192.168.120.112: {}
    192.168.120.114: {}
    192.168.120.115: {}
    192.168.120.116: {}
    192.168.120.117: {}
    192.168.120.118: {}
    192.168.120.119: {}

Do I need any extra dependency to get the feature to work? Is there any log file where I can try what's going on?

[John Fulton (jfulton-org)]

In Pike you need 3 backports see the branch/pike changes in the following:

 https://review.openstack.org/#/q/topic:bug/1736707+(status:open+OR+status:merged)

The 3rd backport that you might be missing is https://review.openstack.org/#/c/528283.

You mentioned an inventory.yaml. Just to be clear, Mistral builds that inventory in /tmp and inserts the extra host variables there as per this patch. It will then clean up the inventory in /tmp.

If you also include this Pike backport https://review.openstack.org/#/c/528741 and in your THT set CephAnsiblePlaybookVerbosity to 1 or greater, then Mistral will not clean up the inventory and you can see exactly how the playbook was run and with what parameters.

Even without the verbosity patch, /var/log/mistral/executor.log should have the ceph-ansible call and /var/log/mistral/ceph-install.log should log the playbook run.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 7.6.7 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/528757
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2b211a057357b4068e444830185f81beebf6bcec
Submitter: Zuul
Branch: stable/pike

commit 2b211a057357b4068e444830185f81beebf6bcec
Author: Giulio Fidente <email address hidden>
Date: Wed Dec 6 14:53:18 2017 +0100

    Passes NodeDataLookup to ceph-ansible workflow

    Per-node customizations were only dumped as hieradata, so the
    ceph-ansible workflow could not consume them.
    This change passes the structure to the mistral workflow so that it
    can consume the data and populate the inventory accordingly.

    Change-Id: Ie7a9f10f0c821b8c642494a4d3933b2901f39d40
    Depends-On: Ia23825aea938f6f9bcf536e35cad562a1b96c93b
    Closes-Bug: #1736707
    (cherry picked from commit 1971e7b049f13a8a2d45fb77412ff1a87ca043c2)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.8 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b3 development milestone.