Delorean fails to detect ZUUL_BRANCH when building rpms

[Emilien Macchi]

If you submit a patch in triploe-ci (which doesn't have stable branch), with a Depends-On on TripleO Heat Templates master, newton/ocata jobs will fail.
In fact, Delorean tries to build the package by using the distgit from master, with the THT code from newton.

See: http://logs.openstack.org/03/523903/7/check-tripleo/tripleo-ci-centos-7-ovb-ha-oooq-newton/2e7c996/logs/delorean_logs/8e/16/8e168a8ddf7ba98fd8f12f5ee0ec1bca0231192f_dev/build.log.txt.gz

This is the patch where you can see the problem: https://review.openstack.org/#/c/523903/

openstack-tripleo-heat-templates-5.3.7-0.20171201030248.8e168a8.el7 - 8e168a8 is the latest commit in stable/newton although the delorean is using the spec file from master, it tried to run " cp -ar common" which doesn't exist in the newton distgit...

[wes hayutin (weshayutin)]

Looking at the review.. I only see CI repos in the changes. AFAICT delorean should not be building any packages for this change. https://review.openstack.org/#/c/523903/

[Javier Peña (jpena-c)]

The issue is in the tripleo-quickstart-extras playbook, see [1]. All changes in the dependency matrix are using "master" as a release, so artg_release is set to master by the playbook (see [2]) and DLRN is configured to use master as a release instead of Newton or Ocata.

I think we could fix it by adding a variable to force the release, and set it accordingly in certain jobs. However, I'm not familiar enough with the playbooks, so I'd appreciate some more insights.

About why THT is built, it looks like Zuul made it a related change, see [3] where it includes https://review.openstack.org/#/c/524346 as a change in Zuul.

[1] - https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/build-test-packages/tasks/main.yml#L119-L124
[2] - http://logs.openstack.org/03/523903/8/check-tripleo/tripleo-ci-centos-7-ovb-ha-oooq-newton/7190c49/job-output.txt.gz#_2017-12-01_06_04_24_895944
[3] - http://logs.openstack.org/03/523903/8/check-tripleo/tripleo-ci-centos-7-ovb-ha-oooq-newton/7190c49/job-output.txt.gz#_2017-12-01_06_04_24_399019

[Daniel Bengtsson (damani42)]

Is this still an issue?