overcloud deploy --config-download returns 0 even when Ansible fails

[Jiří Stránský]

Failed Ansible tasks during openstack overcloud deploy with --config-download option don't result in the deploy command failure. The command still says "Overcloud configuration completed" and returns 0. E.g. this example from CI:

http://logs.openstack.org/88/522488/3/experimental/tripleo-ci-centos-7-scenario006-multinode-oooq/26b088a/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz#_2017-11-27_16_58_29

2017-11-27 16:58:14 | TASK [clone kubespray repo] ****************************************************
2017-11-27 16:58:20 | fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msgHost 192.168.24.11 not found in /home/zuul/.ssh/known_hosts
2017-11-27 16:58:20 | END return value: 0
2017-11-27 16:58:20 | ": "Failed to find required executable git in paths: :/sbin:/usr/sbin:/usr/local/sbin"}
2017-11-27 16:58:20 |
2017-11-27 16:58:20 | NO MORE HOSTS LEFT *************************************************************
2017-11-27 16:58:20 |
2017-11-27 16:58:20 | PLAY RECAP *********************************************************************
2017-11-27 16:58:20 | 192.168.24.3 : ok=83 changed=33 unreachable=0 failed=0
2017-11-27 16:58:20 | localhost : ok=4 changed=0 unreachable=0 failed=1
2017-11-27 16:58:20 |
2017-11-27 16:58:20 |
2017-11-27 16:58:20 |
2017-11-27 16:58:20 | Overcloud configuration completed.
2017-11-27 16:58:20 | Overcloud Endpoint: http://192.168.24.11:5000/
2017-11-27 16:58:20 | Overcloud Deployed
2017-11-27 16:58:20 | + status_code=0
2017-11-27 16:58:20 | + openstack stack list
2017-11-27 16:58:20 | + grep -q overcloud
2017-11-27 16:58:25 | + grep -Eq '(CREATE|UPDATE)_COMPLETE'
2017-11-27 16:58:25 | + openstack stack list
2017-11-27 16:58:29 | + exit 0

[James Slagle (james-slagle)]

this should be fixed by: https://review.openstack.org/#/c/523237/

i had already fixed this prior to this bug being filed.