tripleo

Network gateway validation breaks if undercloud.conf doesn't exist

Bug #1732468 reported by Florian Fuchs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Florian Fuchs
tripleo queens-2

Bug Description

The network gateway validation currently breaks if the undercloud.conf file doesn't exist, due to the missing ``network_gateway`` value. The validation uses the ignore_missing flag on the undercloud conf reader, but fails to set its own default for the network gateway value.

Alex Schultz (alex-schultz)
Changed in tripleo:
importance: Undecided → High
milestone: none → queens-2
Revision history for this message
Julie Pichon (jpichon) wrote :

https://review.openstack.org/#/c/518619/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-validations (master)

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/518619

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (master)

Reviewed: https://review.openstack.org/518619
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=7de584bfe59f540ca26e467578625f3b20e0cefb
Submitter: Zuul
Branch: master

commit 7de584bfe59f540ca26e467578625f3b20e0cefb
Author: Florian Fuchs <email address hidden>
Date: Wed Nov 8 21:10:17 2017 +0000

    Fix the Network Gateway Validation

    The network gateway validation currently breaks if the undercloud.conf
    file doesn't exist, due to the missing ``network_gateway`` value.

    The validation uses the ignore_missing flag on the undercloud conf
    reader, but fails to set its own default for the network gateway value.

    This patch adds this default value.

    Closes-Bug: #1732468

    Change-Id: I47710721323a36616b42455206f779b6f7dda60d

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/pike)

Reviewed: https://review.openstack.org/518743
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=986503ecfeb7c4a3de8837a7aacd23f057802472
Submitter: Zuul
Branch: stable/pike

commit 986503ecfeb7c4a3de8837a7aacd23f057802472
Author: Florian Fuchs <email address hidden>
Date: Wed Nov 8 21:10:17 2017 +0000

    Fix the Network Gateway Validation

    The network gateway validation currently breaks if the undercloud.conf
    file doesn't exist, due to the missing ``network_gateway`` value.

    The validation uses the ignore_missing flag on the undercloud conf
    reader, but fails to set its own default for the network gateway value.

    This patch adds this default value.

    Closes-Bug: #1732468

    Change-Id: I47710721323a36616b42455206f779b6f7dda60d
    (cherry picked from commit 7de584bfe59f540ca26e467578625f3b20e0cefb)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 7.4.3

This issue was fixed in the openstack/tripleo-validations 7.4.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 8.1.0

This issue was fixed in the openstack/tripleo-validations 8.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.