jinja treating 'namespace' as a keyword in tripleo_common tests

Bug #1732453 reported by Brent Eagles
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Triaged
Critical
Unassigned

Bug Description

Certain unit tests in tripleo-common are failing to match computed vs expected results, e.g.:

== Start paste ==
 ... -python} -m subunit.run discover -t ./ . --load-list /tmp/tmpkzaf60rl
2017-11-14 18:18:59.262614 | ubuntu-xenial | ======================================================================
2017-11-14 18:18:59.262646 | ubuntu-xenial | FAIL: tripleo_common.tests.image.test_kolla_builder.TestKollaImageBuilderTemplate.test_container_images_from_template_filter
2017-11-14 18:18:59.262659 | ubuntu-xenial | tags: worker-2

<< snip >>

2017-11-14 18:18:59.262905 | ubuntu-xenial | testtools.matchers._impl.MismatchError: !=:
2017-11-14 18:18:59.262927 | ubuntu-xenial | reference = [{'imagename': 'tripleoupstream/centos-binary-nova-compute:liberty',
2017-11-14 18:18:59.262940 | ubuntu-xenial | 'pull_source': 'docker.io',
2017-11-14 18:18:59.262954 | ubuntu-xenial | 'push_destination': 'localhost:8787',
2017-11-14 18:18:59.262965 | ubuntu-xenial | 'uploader': 'docker'},
2017-11-14 18:18:59.262985 | ubuntu-xenial | {'imagename': 'tripleoupstream/centos-binary-nova-libvirt:liberty',

<< snip >>

2017-11-14 18:18:59.263053 | ubuntu-xenial | 'pull_source': 'docker.io',
2017-11-14 18:18:59.263067 | ubuntu-xenial | 'push_destination': 'localhost:8787'}]
2017-11-14 18:18:59.263081 | ubuntu-xenial | actual = [{'imagename': '<class '
2017-11-14 18:18:59.263103 | ubuntu-xenial | "'jinja2.utils.Namespace'>/centos-binary-nova-compute:liberty",

<< snip >>

== End paste ==

On a hunch, I replaced all instances of 'namespace' in jinja strings and files with something else (like 'ugh' or 'ns') and the tests succeeded. Perhaps this is a known issue in jinja, a regression or simply a breaking change that we need to adapt to?

Brent Eagles (beagles)
Changed in tripleo:
status: New → Triaged
importance: Undecided → Critical
Revision history for this message
Julie Pichon (jpichon) wrote :

Seems like a duplicate of bug 1732140, which turns out to be resolved by https://review.openstack.org/#/c/516136/ - has all the right votes but struggling to merge unfortunately.

Revision history for this message
Brent Eagles (beagles) wrote :

Thanks Julie. I missed this in my search! It is indeed a duplicate. The referenced bug covers the exact same findings as well (version 2.10 yada yada).

Changed in tripleo:
importance: Critical → Undecided
importance: Undecided → Critical
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.