haproxy defaults_options are not adjustable/overridable

Bug #1732176 reported by Jiří Stránský on 2017-11-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Michele Baldessari

Bug Description

Currently we hardcode haproxy options for the `defaults` section of haproxy.cfg:

https://github.com/openstack/puppet-tripleo/blob/bd443a3ac78e4e5689f3c20bf9a41a51d073e864/manifests/haproxy.pp#L828-L834

Except for the timeout/maxconn variables, user cannot customize the defaults section. We should have $haproxy_defaults_override similarly as we have $haproxy_globals_override:

https://github.com/openstack/puppet-tripleo/blob/bd443a3ac78e4e5689f3c20bf9a41a51d073e864/manifests/haproxy.pp#L827

summary: - haproxy defaults_options are hardcoded and not adjustable
+ haproxy defaults_options are not adjustable/overridable
Changed in tripleo:
milestone: queens-2 → queens-3

Fix proposed to branch: master
Review: https://review.openstack.org/532141

Changed in tripleo:
assignee: nobody → Michele Baldessari (michele)
status: Triaged → In Progress

Reviewed: https://review.openstack.org/532141
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=37f0c004c5a80653d25a71a0292e26bad73ad3e1
Submitter: Zuul
Branch: master

commit 37f0c004c5a80653d25a71a0292e26bad73ad3e1
Author: Michele Baldessari <email address hidden>
Date: Tue Jan 9 10:59:29 2018 +0100

    Let haproxy_defaults be overridable

    Add the haproxy_defaults_override parameter so the defaults_options
    in haproxy are overridable. Tested by adding the following yaml to
    the deployment:
    parameter_defaults:
      ExtraConfig:
        tripleo::haproxy::haproxy_defaults_override:
          retries: 7

    Observed that haproxy.conf contained the following (retries defaults
    to 3):
    defaults
      retries 7

    Change-Id: I52b8f528e334e4d243ac7f506b9f293dab9f478d
    Closes-Bug: #1732176

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/puppet-tripleo 8.2.0 release.

Reviewed: https://review.openstack.org/584510
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=d3e20ebe909c8a15ff069448d34805ceb428174a
Submitter: Zuul
Branch: stable/pike

commit d3e20ebe909c8a15ff069448d34805ceb428174a
Author: Michele Baldessari <email address hidden>
Date: Tue Jan 9 10:59:29 2018 +0100

    Let haproxy_defaults be overridable

    Add the haproxy_defaults_override parameter so the defaults_options
    in haproxy are overridable. Tested by adding the following yaml to
    the deployment:
    parameter_defaults:
      ExtraConfig:
        tripleo::haproxy::haproxy_defaults_override:
          retries: 7

    Observed that haproxy.conf contained the following (retries defaults
    to 3):
    defaults
      retries 7

    Change-Id: I52b8f528e334e4d243ac7f506b9f293dab9f478d
    Closes-Bug: #1732176
    (cherry picked from commit 37f0c004c5a80653d25a71a0292e26bad73ad3e1)

tags: added: in-stable-pike

This issue was fixed in the openstack/puppet-tripleo 7.4.15 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers