dlrn_hash_tag is undefined failing ovb jobs in pike/master promotion

[wes hayutin]

https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset020-master/25659a9/console.txt.gz#_2017-11-09_15_09_13_899

2017-11-09 15:09:13.899 | task path: /home/jenkins/workspace/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset020-master/.quickstart/usr/local/share/ansible/roles/overcloud-prep-images/tasks/create-scripts.yml:3
2017-11-09 15:09:13.899 | Thursday 09 November 2017 15:09:13 +0000 (0:00:00.073) 0:42:32.714 *****
2017-11-09 15:09:13.899 | fatal: [undercloud]: FAILED! => {"changed": false, "failed": true, "msg": "AnsibleUndefinedVariable: http://images.rdoproject.org/{{ release }}/rdo_trunk/{{ dlrn_hash|default(dlrn_hash_tag) }}/overcloud-full.tar: 'dlrn_hash_tag' is undefined"}

see http://38.145.34.234/ for details on the master/pike ovb jobs

[Ronelle Landy (rlandy)]

These jobs fail because dlrn_hash_tag is not defined in the promotion-testing-hash-* files in https://github.com/openstack/tripleo-quickstart/tree/master/config/release/tripleo-ci.

The images are defined as:

https://github.com/openstack/tripleo-quickstart/blob/master/config/release/tripleo-ci/promotion-testing-hash-master.yml#L25

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/518808

[Ronelle Landy (rlandy)]

adarazs: please confirm if we need the changes in master and ocata as well.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/518808
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=21fd2d1568c022877cf90c7594c6a179bae91fb9
Submitter: Zuul
Branch: master

commit 21fd2d1568c022877cf90c7594c6a179bae91fb9
Author: Ronelle Landy <email address hidden>
Date: Thu Nov 9 18:02:24 2017 -0500

    Add dlrn_hash_tag to promotion-testing-hash config files

    The change to use a specific dlrn_hash missed updating the
    config files used in promotion jobs.
    This review adds the dlrn_hash_tag and related references in
    images, repos, and docker_image_tags.

    Change-Id: I9a8b22a5de836dc4924fe4f47b16f8113afc5778
    Closes-bug: #1731346

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart 2.1.1 release.