legacy-puppet-syntax-3 job missing on instack-undercloud stable/newton branch

[Alex Schultz]

The zuul configuration is not correct for stable/newton on instack-undercloud causing zuul to -1 because it cannot find the playbook for the legacy-puppet-syntax-3-centos-7 job.

See https://review.openstack.org/#/c/517356/

legacy-puppet-syntax-3-centos-7 legacy-puppet-syntax-3-centos-7 : ERROR Unable to find playbook /var/lib/zuul/builds/87b687b9031544a2a104f242be3e0a5a/trusted/project_2/git.openstack.org/openstack-infra/openstack-zuul-jobs/playbooks/legacy/puppet-syntax-3-centos-7/run.yaml

[Attila Darazs (adarazs)]

It seems to me that the correct playbook to call would be https://github.com/openstack-infra/openstack-zuul-jobs/blob/master/playbooks/legacy/puppet-syntax-3/run.yaml

It has the comment "Autoconverted job legacy-puppet-syntax-3 from old job gate-{name}-puppet-syntax-3-ubuntu-xenial" in it, but it seems that this job was actually a centos based one, judging from the commands in the shell part.

The diff is very small between this playbook and https://github.com/openstack-infra/openstack-zuul-jobs/blob/master/playbooks/legacy/puppet-syntax-4-centos-7/run.yaml which is really a centos job.

I think we need to fix the called playbook in https://github.com/openstack-infra/openstack-zuul-jobs/blob/d46fb94e5699729bb8f8079fcd2a83abd85b31da/zuul.d/zuul-legacy-jobs.yaml#L4704 or rename the playbook.

[Attila Darazs (adarazs)]

Fix posted at https://review.openstack.org/518347

[Attila Darazs (adarazs)]

Correct solution at https://review.openstack.org/518362

[Jiří Stránský (jistr)]

The fix is merged.