yum-plugin-priorities is not installed in tripleo image when overcloud packages are installed

[Alfredo Moralejo]

When deploying TripleO from RDO Trunk (dlrn) repos, we rely on yum priorites to get packages from the hash repos instead of the dependencies one when different versions of the same packages are present.

yum priorites needs to have the package yum-plugin-priorities present. When building images, we pass "yum-plugin-priorities" to disk-image-create in '-p' option [1]. However a patch in dib [2] changed the order in which packages in '-p' are installed and moved after package installation from the elements, which broke this

[1] https://logs.rdoproject.org/openstack-periodic-4hr/periodic-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset002-master-upload/72d0be2/undercloud/home/jenkins/overcloud_image_build.log.txt.gz#_2017-10-26_18_01_51

[2] https://github.com/openstack/diskimage-builder/commit/95503b42017a3b96f810e3195d8edaa64995ce78

[Alfredo Moralejo (amoralej)]

https://review.openstack.org/#/c/508870/ will workaround this issue, but it's still a bug that needs to be fixed, imo

[Alan Pevec (apevec)]

It would be also worked around when all projects get first milestone tags on master and looks like neutron-lbaas didn't have one yet, so its trunk RPMs have lower pre-release NVR.

[Alan Pevec (apevec)]

508870 was merged but this bug should stay open as a tech-debt to chase the "yum-plugin-priorities" issue down

[Alan Pevec (apevec)]

Should this be fixed in DIB or OOOQ ?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/516765

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/516765
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=cc606ef52757adb438639f736bb505d4ffd2c56b
Submitter: Zuul
Branch: master

commit cc606ef52757adb438639f736bb505d4ffd2c56b
Author: Alfredo Moralejo <email address hidden>
Date: Tue Oct 31 19:36:07 2017 +0100

    Install yum-plugin-priorities in pre-install phase

    In some cases yum repositories are using priorities configuration
    to force OpenStack packages to be installed from the desired
    repository.

    To work properly, priorities configuration requires the package
    yum-plugin-priorities to be installed before doing the actual
    OpenStack packages installation.

    This patch adds yum-plugin-priorities in pre-install phase for
    overcloud-base element wich is always used when creating
    tripleo images.

    Change-Id: I9c9b50d35d411f85a4cbe33ffab4c71d40dfb0f1
    Closes-Bug: #1727985

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-puppet-elements 8.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/531107

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/531107
Reason: The gate is currently timeouting, we need https://review.openstack.org/#/c/531352/ to improve the situation. I'll restore the patch once the gate is stable again. Please do not recheck or restore this patch, I'll take care of it. Thanks for your patience.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531107
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=a2422e5832baf0c86ff1e1b27d23418f8c87b57b
Submitter: Zuul
Branch: stable/pike

commit a2422e5832baf0c86ff1e1b27d23418f8c87b57b
Author: Alfredo Moralejo <email address hidden>
Date: Tue Oct 31 19:36:07 2017 +0100

    Install yum-plugin-priorities in pre-install phase

    In some cases yum repositories are using priorities configuration
    to force OpenStack packages to be installed from the desired
    repository.

    To work properly, priorities configuration requires the package
    yum-plugin-priorities to be installed before doing the actual
    OpenStack packages installation.

    This patch adds yum-plugin-priorities in pre-install phase for
    overcloud-base element wich is always used when creating
    tripleo images.

    Change-Id: I9c9b50d35d411f85a4cbe33ffab4c71d40dfb0f1
    Closes-Bug: #1740934
    Closes-Bug: #1727985
    (cherry picked from commit cc606ef52757adb438639f736bb505d4ffd2c56b)

    yum-plugin-priorities should not be enabled on RHEL

    Change-Id: Ic3721f0fbd35eb421d439e53ff8418293f83d4af
    (cherry picked from commit 82d0a62d85fafae218414d551191dc1fd3f639d5)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-puppet-elements 7.0.4 release.