RHSM proxy can be down, users will never now

Bug #1724970 reported by Emilien Macchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
VIncent S. Cojot

Bug Description

When using rhel_reg_http_proxy_* parameters for RHEL subscription, TripleO will never check if the proxy is actually available. If it's not, it will fail and the poor user will never know why (it will probably timeout).

TripleO could be nice and fail early if the proxy isn't ready, and send a nice message so the user knows what to do.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/513530

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
assignee: Emilien Macchi (emilienm) → VIncent S. Cojot (vincent-m)
Changed in tripleo:
assignee: VIncent S. Cojot (vincent-m) → Emilien Macchi (emilienm)
Changed in tripleo:
assignee: Emilien Macchi (emilienm) → VIncent S. Cojot (vincent-m)
Changed in tripleo:
assignee: VIncent S. Cojot (vincent-m) → Emilien Macchi (emilienm)
Changed in tripleo:
assignee: Emilien Macchi (emilienm) → VIncent S. Cojot (vincent-m)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/513530
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f4e46f4b3ddac3f536a3a1955c91447e8b26ffca
Submitter: Zuul
Branch: master

commit f4e46f4b3ddac3f536a3a1955c91447e8b26ffca
Author: Emilien Macchi <email address hidden>
Date: Thu Oct 19 14:39:36 2017 -0700

    RHSM: when using proxy, test its connectivity first

    When using RHSM with a proxy, we want to make sure the proxy can be
    reached. This patch verify that a tcp socket can be open from the client
    to the proxy.

    This patch also does a bit of refactoring:
    - --retry-delay 10 --max-time 30 is now used in a parameter everytime we
      use curl.
    - proxy options are now used everytime curl is used, even for detecting
      which version of Satellite is running, now we use proxy options.

    Co-Authored-By: Vincent S. Cojot <email address hidden>
    Change-Id: I4dcac1528c10f698338383445e27c8a613f9bcd9
    Closes-Bug: #1724970

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/517442

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/517443

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/517448

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/ocata)

Reviewed: https://review.openstack.org/517448
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d5c62813a67b94d84158ab5e12c94e2369279ccd
Submitter: Zuul
Branch: stable/ocata

commit d5c62813a67b94d84158ab5e12c94e2369279ccd
Author: Emilien Macchi <email address hidden>
Date: Thu Oct 19 14:39:36 2017 -0700

    RHSM: when using proxy, test its connectivity first

    When using RHSM with a proxy, we want to make sure the proxy can be
    reached. This patch verify that a tcp socket can be open from the client
    to the proxy.

    This patch also does a bit of refactoring:
    - --retry-delay 10 --max-time 30 is now used in a parameter everytime we
      use curl.
    - proxy options are now used everytime curl is used, even for detecting
      which version of Satellite is running, now we use proxy options.

    Co-Authored-By: Vincent S. Cojot <email address hidden>
    Change-Id: I4dcac1528c10f698338383445e27c8a613f9bcd9
    Closes-Bug: #1724970
    (cherry picked from commit f4e46f4b3ddac3f536a3a1955c91447e8b26ffca)

tags: added: in-stable-ocata
tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/pike)

Reviewed: https://review.openstack.org/517443
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1b1739c5ebf677ba12ad53a6b11785471e5f52b5
Submitter: Zuul
Branch: stable/pike

commit 1b1739c5ebf677ba12ad53a6b11785471e5f52b5
Author: Emilien Macchi <email address hidden>
Date: Thu Oct 19 14:39:36 2017 -0700

    RHSM: when using proxy, test its connectivity first

    When using RHSM with a proxy, we want to make sure the proxy can be
    reached. This patch verify that a tcp socket can be open from the client
    to the proxy.

    This patch also does a bit of refactoring:
    - --retry-delay 10 --max-time 30 is now used in a parameter everytime we
      use curl.
    - proxy options are now used everytime curl is used, even for detecting
      which version of Satellite is running, now we use proxy options.

    Co-Authored-By: Vincent S. Cojot <email address hidden>
    Change-Id: I4dcac1528c10f698338383445e27c8a613f9bcd9
    Closes-Bug: #1724970
    (cherry picked from commit f4e46f4b3ddac3f536a3a1955c91447e8b26ffca)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/newton)

Reviewed: https://review.openstack.org/517442
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0333ff9e622a2c0704aafbed4a137e6fd940704d
Submitter: Zuul
Branch: stable/newton

commit 0333ff9e622a2c0704aafbed4a137e6fd940704d
Author: Emilien Macchi <email address hidden>
Date: Thu Oct 19 14:39:36 2017 -0700

    RHSM: when using proxy, test its connectivity first

    When using RHSM with a proxy, we want to make sure the proxy can be
    reached. This patch verify that a tcp socket can be open from the client
    to the proxy.

    This patch also does a bit of refactoring:
    - --retry-delay 10 --max-time 30 is now used in a parameter everytime we
      use curl.
    - proxy options are now used everytime curl is used, even for detecting
      which version of Satellite is running, now we use proxy options.

    Co-Authored-By: Vincent S. Cojot <email address hidden>
    Change-Id: I4dcac1528c10f698338383445e27c8a613f9bcd9
    Closes-Bug: #1724970
    (cherry picked from commit f4e46f4b3ddac3f536a3a1955c91447e8b26ffca)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 5.3.5

This issue was fixed in the openstack/tripleo-heat-templates 5.3.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 7.0.4

This issue was fixed in the openstack/tripleo-heat-templates 7.0.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 6.2.5

This issue was fixed in the openstack/tripleo-heat-templates 6.2.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.0.0.0b2

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.