httpd should listen on localhost for server-status

Bug #1724751 reported by Cédric Jeanneret deactivated
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Cédric Jeanneret deactivated

Bug Description

Dear Stackers,

Wanting to get some httpd stats on my Pike infrastructure, I found out that the server-status module is enabled. Great. But there's a small issue:
its configuration wants connection from localhost (127.0.0.1 or ::1), but apparently, httpd isn't listening on that interface.

It would be great if httpd "ports.conf" could be modified in order to add a "Listen 127.0.0.1:80" (or whatever port) so that we can, with collectd, collect httpd metrics.

Thank you!

Cheers,

C.

Revision history for this message
Cédric Jeanneret deactivated (cjeanneret-c2c-deactivated) wrote :

After some researches, it appears the "status" module is included here:
https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/horizon.pp#L88

It would be great to add the Listen thingy in the same place, in order to keep it consistent. Another possibility would be to modify puppet-horizon in order to add the Listen part alongside the current one, but it might confuse people using this module outside of tripleo.

Changed in tripleo:
assignee: nobody → Cédric Jeanneret (cjeanneret-c2c)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.openstack.org/513274

Changed in tripleo:
status: New → In Progress
Steven Hardy (shardy)
Changed in tripleo:
importance: Undecided → Medium
milestone: none → queens-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-tripleo (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/513274
Reason: Clearing the gate now, see context on http://lists.openstack.org/pipermail/openstack-dev/2017-October/123979.html
I'll restore the patch once we're green. Apologizes in advance and don't worry for your patch, it will merge asap.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/513274
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=0933bc5fd896ac2474872bb1b4b217ad8f430885
Submitter: Zuul
Branch: master

commit 0933bc5fd896ac2474872bb1b4b217ad8f430885
Author: Cédric Jeanneret <email address hidden>
Date: Thu Oct 19 08:32:09 2017 +0200

    Create dedicated "apache" base profile

    This profile has multiple purposes:
    - group common httpd configurations/instructions
    - correct a small issue with the "status" mod

    Until now, only Horizon was specifically including this mode, and as
    httpd wasn't listening on localhost, it wasn't in use at all.

    With this commit, all API using apache will be able to provide the httpd
    server status on 127.0.0.1/server-status.

    Change-Id: If6d64f807c244d7e56852a67ac7dbad26c4c002f
    Closes-Bug: 1724751

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/519326

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/pike)

Reviewed: https://review.openstack.org/519326
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=8eafd014a8c01826d50c12444271973aace8961b
Submitter: Zuul
Branch: stable/pike

commit 8eafd014a8c01826d50c12444271973aace8961b
Author: Cédric Jeanneret <email address hidden>
Date: Thu Oct 19 08:32:09 2017 +0200

    Create dedicated "apache" base profile

    This profile has multiple purposes:
    - group common httpd configurations/instructions
    - correct a small issue with the "status" mod

    Until now, only Horizon was specifically including this mode, and as
    httpd wasn't listening on localhost, it wasn't in use at all.

    With this commit, all API using apache will be able to provide the httpd
    server status on 127.0.0.1/server-status.

    Change-Id: If6d64f807c244d7e56852a67ac7dbad26c4c002f
    Closes-Bug: 1724751
    (cherry picked from commit 0933bc5fd896ac2474872bb1b4b217ad8f430885)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 7.4.5

This issue was fixed in the openstack/puppet-tripleo 7.4.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 8.1.0

This issue was fixed in the openstack/puppet-tripleo 8.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/532739

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/532742

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/ocata)

Reviewed: https://review.openstack.org/532739
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=8ffd426aaf93963a331bdb5895b1e27afce959b7
Submitter: Zuul
Branch: stable/ocata

commit 8ffd426aaf93963a331bdb5895b1e27afce959b7
Author: Cédric Jeanneret <email address hidden>
Date: Thu Oct 19 08:32:09 2017 +0200

    Create dedicated "apache" base profile

    This profile has multiple purposes:
    - group common httpd configurations/instructions
    - correct a small issue with the "status" mod

    Until now, only Horizon was specifically including this mode, and as
    httpd wasn't listening on localhost, it wasn't in use at all.

    With this commit, all API using apache will be able to provide the httpd
    server status on 127.0.0.1/server-status.

    Change-Id: If6d64f807c244d7e56852a67ac7dbad26c4c002f
    Closes-Bug: 1724751
    (cherry picked from commit 0933bc5fd896ac2474872bb1b4b217ad8f430885)
    (cherry picked from commit 8eafd014a8c01826d50c12444271973aace8961b)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/newton)

Reviewed: https://review.openstack.org/532742
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=e807e860fd3f7ff16f376af9cd425f46f9d2a402
Submitter: Zuul
Branch: stable/newton

commit e807e860fd3f7ff16f376af9cd425f46f9d2a402
Author: Cédric Jeanneret <email address hidden>
Date: Thu Oct 19 08:32:09 2017 +0200

    Create dedicated "apache" base profile

    This profile has multiple purposes:
    - group common httpd configurations/instructions
    - correct a small issue with the "status" mod

    Until now, only Horizon was specifically including this mode, and as
    httpd wasn't listening on localhost, it wasn't in use at all.

    With this commit, all API using apache will be able to provide the httpd
    server status on 127.0.0.1/server-status.

    Change-Id: If6d64f807c244d7e56852a67ac7dbad26c4c002f
    Closes-Bug: 1724751
    (cherry picked from commit ca7239a5dc047c2c0aa5f8dc52205594c97469d3)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 5.6.7

This issue was fixed in the openstack/puppet-tripleo 5.6.7 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 6.5.8

This issue was fixed in the openstack/puppet-tripleo 6.5.8 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.