Missing disable_upgrade_deployment flag in deployed-server-roles-data.yaml

[Emilien Macchi]

deployed-server-roles-data.yaml shipped in THT doesn't include the disable_upgrade_deployment flag for compute and objectstorage roles. These are needed for being able to disable upgrade on non controller nodes so the operator can upgrade them individually.

Also the roles_data.yaml provided in the tht root looks quite different than deployed-server/deployed-server-roles-data.yaml, including the new networks attributes and several other options so I suspect we need to add these new options in deployed-server-roles-data.yaml as well?

Bug reported here by Marius: https://bugzilla.redhat.com/show_bug.cgi?id=1500832

This launchpad is a stackholder so we can backport it to stable/pike.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/511523

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/511523
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0e6c86dc123e9f558c4d3d594ff50e85dd00171f
Submitter: Jenkins
Branch: master

commit 0e6c86dc123e9f558c4d3d594ff50e85dd00171f
Author: Emilien Macchi <email address hidden>
Date: Thu Oct 12 09:33:29 2017 -0700

    Sync deployed-server-roles-data and roles-data

    deployed-server-roles-data was out of sync and missing some parameters
    introduced in Pike cycle:
    This patch syncs the roles_data between 2 files.

    Change-Id: If4a8388634fb1dcbb47beeabbd3db005abc80d4e
    Closes-Bug: #1723177

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/512298

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/512343

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/512343
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6e7a431df0b7790512eb1920500b8878701c691a
Submitter: Zuul
Branch: master

commit 6e7a431df0b7790512eb1920500b8878701c691a
Author: James Slagle <email address hidden>
Date: Mon Oct 16 12:06:02 2017 -0400

    Remove deprecation handling from custom roles

    For deployed-server custom roles, the deprecation handlings are removed.
    As these have always been custom roles with definitions generated from
    role.role.j2.yaml, these original (now deprecated) param names were
    never present for anyone using this deployed-server roles data file.

    Specifically, deprecated_server_resource_name is quite troublesome as it
    will cause the server resources to get replaced on upgrade as the
    resource name changes.

    These were all introduced in If4a8388634fb1dcbb47beeabbd3db005abc80d4e,
    and this commit removes them.

    Change-Id: I1c1267f19db972b55466f4649eda62dd7814b94a
    Closes-Bug: #1723177

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/512445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/512298
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=98d138913df2092f56627b0c8f61e4b214d1e2ea
Submitter: Zuul
Branch: stable/pike

commit 98d138913df2092f56627b0c8f61e4b214d1e2ea
Author: Emilien Macchi <email address hidden>
Date: Thu Oct 12 09:33:29 2017 -0700

    Sync deployed-server-roles-data and roles-data

    deployed-server-roles-data was out of sync and missing some parameters
    introduced in Pike cycle:
    This patch syncs the roles_data between 2 files.

    Change-Id: If4a8388634fb1dcbb47beeabbd3db005abc80d4e
    Closes-Bug: #1723177
    (cherry picked from commit 0e6c86dc123e9f558c4d3d594ff50e85dd00171f)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/512445
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=09dbd6733cba19939a51fe61e94a1162ee7883e7
Submitter: Zuul
Branch: stable/pike

commit 09dbd6733cba19939a51fe61e94a1162ee7883e7
Author: James Slagle <email address hidden>
Date: Mon Oct 16 12:06:02 2017 -0400

    Remove deprecation handling from custom roles

    For deployed-server custom roles, the deprecation handlings are removed.
    As these have always been custom roles with definitions generated from
    role.role.j2.yaml, these original (now deprecated) param names were
    never present for anyone using this deployed-server roles data file.

    Specifically, deprecated_server_resource_name is quite troublesome as it
    will cause the server resources to get replaced on upgrade as the
    resource name changes.

    These were all introduced in If4a8388634fb1dcbb47beeabbd3db005abc80d4e,
    and this commit removes them.

    Change-Id: I1c1267f19db972b55466f4649eda62dd7814b94a
    Closes-Bug: #1723177
    (cherry picked from commit 6e7a431df0b7790512eb1920500b8878701c691a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.3 release.