Error handling errors in validation workflows. Task 'check_flavors' error=Can not evaluate YAQL expression

[Dougal Matthews]

In the check_flavors workflow, the following error will happen if the check_flavors action fails.

YaqlEvaluationException: Can not evaluate YAQL expression [expression=task(check_flavors).result.errors, error=Unknown function "#property#errors", data={}]

The YAQL is....

    errors: <% $.errors + task(collect_flavors).result.errors %>

I think on error, the result value might be a string. Meaning that we can't access an errors property.

I also suspect the error handling in some of the other tasks here might not be correct.

[Dougal Matthews (d0ugal)]

This is related to https://bugs.launchpad.net/tripleo/+bug/1723171

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/535912

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/535912
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=25170a889ac834cfde84b988061838b35891dcce
Submitter: Zuul
Branch: master

commit 25170a889ac834cfde84b988061838b35891dcce
Author: Brad P. Crochet <email address hidden>
Date: Fri Jan 19 14:36:27 2018 -0500

    Make the validations workflow a bit more robust

    The validations workflows would fail in strange ways in certain
    conditions. This refactors the workflows a bit and makes the result
    checking more robust by using the get() yaql function.

    Change-Id: I6e37df8989cab507c4f404094d127db1bac51c1b
    Closes-Bug: #1723170

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.5.0 release.