[quickstart] template improperly injecting http/https into config file

Bug #1722674 reported by Jason E. Rist on 2017-10-10
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tripleo
High
Jason E. Rist

Bug Description

When trying to tunnel into the undercloud, I attempt to use the built-in ssh-tunnel service on the virthost. When I try to start it at the command line (systemctl start ssh-tunnel.service) it presents me with information that it failed. Upon investigation I can see that the config file resembles the following:
http://paste.openstack.org/show/623278/

Clearly for an ssh-tunnel to work, it can't have the https:// in the IP address.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-quickstart (master)

Fix proposed to branch: master
Review: https://review.openstack.org/511143

Changed in tripleo:
assignee: Jason E. Rist (jason-rist) → Sagi (Sergey) Shnaidman (sshnaidm)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/511251

Changed in tripleo:
assignee: Sagi (Sergey) Shnaidman (sshnaidm) → Jason E. Rist (jason-rist)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-quickstart (master)

Change abandoned by Jason E. Rist (<email address hidden>) on branch: master
Review: https://review.openstack.org/511251
Reason: already a patch up https://review.openstack.org/#/c/511143/

Changed in tripleo:
milestone: queens-1 → queens-2
Revision history for this message
wes hayutin (weshayutin) wrote :

I have this working w/ pike
https://review.openstack.org/#/c/514758/

Updated doc and config

Revision history for this message
wes hayutin (weshayutin) wrote :

How to test after merge:
 export WD=/var/tmp/pike; ./quickstart.sh -R tripleo-ci/pike -w $WD --no-clone <virthost>
or
 export WD=/var/tmp/pike; ./quickstart.sh -R pike -w $WD --no-clone <virthost>

Revision history for this message
wes hayutin (weshayutin) wrote :

To test w/ patches, pull in the latest patches w/ git-review or $other
Then update your requirements

 cat quickstart-extras-requirements.txt
file:///<dir>/tripleo-quickstart-extras/#egg=tripleo-quickstart-extras

Invoke quickstart.sh w/ --no-clone

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-quickstart (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/514795

Revision history for this message
wes hayutin (weshayutin) wrote :

adds the start of some basic testing for the tripleo-ui after a tripleo-quickstart run
https://review.openstack.org/514795

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-quickstart (master)

Reviewed: https://review.openstack.org/511143
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=d92ea2c7aa707bf0dec7681f2dd6d3bd2511c6b4
Submitter: Zuul
Branch: master

commit d92ea2c7aa707bf0dec7681f2dd6d3bd2511c6b4
Author: Sagi Shnaidman <email address hidden>
Date: Wed Oct 11 08:42:08 2017 +0300

    Fix IP address for ssh-tunnel for UI

    Port forwarding should be without http/s in configuration
    Closes-Bug: #1722674

    Change-Id: Iba1928441916cb6fa3261b40d23ecbd4717fb6ff

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-quickstart (master)

Reviewed: https://review.openstack.org/514758
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=b0d042e53c5e69d68482303f224d14cc01deb55e
Submitter: Zuul
Branch: master

commit b0d042e53c5e69d68482303f224d14cc01deb55e
Author: Wes Hayutin <email address hidden>
Date: Tue Oct 24 12:43:40 2017 -0400

    update tripleo_ui_secure_access to true by default

    The TripleO-UI now works quite well with security
    enabled for the TripleO-UI. Turning it on by default.

    Related-Bug: #1722674
    Depends-On: Ibc1652a63da4fb4c9ccf004f77aa18a3d81b490d
    Change-Id: I3d3412e2299ea70321785d57ec905bff569c8ab8

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/514795
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=627b955b82243e631fddda988d0a7068f77f457e
Submitter: Zuul
Branch: master

commit 627b955b82243e631fddda988d0a7068f77f457e
Author: Wes Hayutin <email address hidden>
Date: Tue Oct 24 14:59:33 2017 -0400

    add basic/simple tests for the tripleo-ui

    Starting simple with just a curl test.
    We need to ensure the tripleo-ui is always
    working after a deployment.

    Related-Bug: #1722674
    Depends-On: Ie320cf86a6d6d2bc810221e18f4be5e029c26df2
    Change-Id: If1fb7d94cd28364c23efae4bb716e64ac6db93f4

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-quickstart 2.1.1

This issue was fixed in the openstack/tripleo-quickstart 2.1.1 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers