hieradata_override doesn't work with relative path

[Thomas Herve]

When using quickstart, it sets this in the undercloud config:

hieradata_override = hieradata-overrides-classic-undercloud.yaml

When you try to run undercloud upgrade from somewhere different than home, it fails:

2017-10-10 09:10:51,359 DEBUG: An exception occurred
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1759, in install
    _generate_init_data(instack_env)
  File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1264, in _generate_init_data
    _run_command(['sudo', 'cp', CONF.hieradata_override, dst])
  File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 576, in _run_command
    env=env).decode('utf-8')
  File "/usr/lib64/python2.7/subprocess.py", line 575, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '['sudo', 'cp', 'hieradata-overrides-classic-undercloud.yaml', '/etc/puppet/hieradata/hieradata-overrides-classic-undercloud.yaml']' returned non-zero exit status 1
2017-10-10 09:10:51,401 ERROR:

The script should resolve the relative path from the config instead.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/510813

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/510813
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=19f983db77f7d75d4d661acd2c23b894ca94dd60
Submitter: Zuul
Branch: master

commit 19f983db77f7d75d4d661acd2c23b894ca94dd60
Author: Thomas Herve <email address hidden>
Date: Tue Oct 10 11:57:40 2017 +0200

    Handle relative hieradata_override

    It fixes an issue with hieradata_override when the path is relative.
    It also aligns the behavior for undercloud_service_certificate.

    Change-Id: Id7a49617712c5d4c15fcce8c552026f88ca39625
    Closes-Bug: #1722489

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/513759

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/513759
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=9d45df482574d6e2497838f9b3a7cc048270e64d
Submitter: Zuul
Branch: stable/pike

commit 9d45df482574d6e2497838f9b3a7cc048270e64d
Author: Thomas Herve <email address hidden>
Date: Tue Oct 10 11:57:40 2017 +0200

    Handle relative hieradata_override

    It fixes an issue with hieradata_override when the path is relative.
    It also aligns the behavior for undercloud_service_certificate.

    Change-Id: Id7a49617712c5d4c15fcce8c552026f88ca39625
    Closes-Bug: #1722489
    (cherry picked from commit 19f983db77f7d75d4d661acd2c23b894ca94dd60)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 7.4.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 8.1.0 release.