tripleo

CephConfigOverrides is overwriting the ceph.conf global section, not appending to it

Bug #1719919 reported by Giulio Fidente
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Giulio Fidente
tripleo queens-1

Bug Description

Purpose of CephConfigOverrides is to override settings possibly found in ceph.conf[global] section but it is currently replacing the contents, not appending/overriding them.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/507880

Changed in tripleo:
assignee: nobody → Giulio Fidente (gfidente)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-docs (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/507882

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/507880
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=17416dcfc56c5148ccc9ab40297f99adfdcd085b
Submitter: Jenkins
Branch: master

commit 17416dcfc56c5148ccc9ab40297f99adfdcd085b
Author: Giulio Fidente <email address hidden>
Date: Wed Sep 27 16:39:19 2017 +0200

    Make CephConfigOverrides append to ceph.conf[global]

    Previously it was mistakenly replacing the contents because we
    do not do deep merge.

    Change-Id: I145feb0208f135da7c71694ebcecd937244d66b1
    Closes-Bug: #1719919

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/508059

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/pike)

Reviewed: https://review.openstack.org/508059
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f2d8fa73f6cec2e3d754dbd9a9973918cc9832d0
Submitter: Jenkins
Branch: stable/pike

commit f2d8fa73f6cec2e3d754dbd9a9973918cc9832d0
Author: Giulio Fidente <email address hidden>
Date: Wed Sep 27 16:39:19 2017 +0200

    Make CephConfigOverrides append to ceph.conf[global]

    Previously it was mistakenly replacing the contents because we
    do not do deep merge.

    Change-Id: I145feb0208f135da7c71694ebcecd937244d66b1
    Closes-Bug: #1719919
    (cherry picked from commit 17416dcfc56c5148ccc9ab40297f99adfdcd085b)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-docs (master)

Reviewed: https://review.openstack.org/507882
Committed: https://git.openstack.org/cgit/openstack/tripleo-docs/commit/?id=e098f34a35871544ba6758352c99dd1207a79704
Submitter: Jenkins
Branch: master

commit e098f34a35871544ba6758352c99dd1207a79704
Author: Giulio Fidente <email address hidden>
Date: Wed Sep 27 16:42:53 2017 +0200

    Fix use of CephAnsibleExtraConfig and CephConfigOverrides

    Uses better (shorter) examples to distinguish better which one is
    to be used for what.

    Change-Id: I51341fb3aa72106e48241a97c89bb3a7bc1d6fb8
    Depends-On: I145feb0208f135da7c71694ebcecd937244d66b1
    Related-Bug: #1719919

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 7.0.2

This issue was fixed in the openstack/tripleo-heat-templates 7.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.0.0.0b1

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.