Healthchecks may not have the right permissions

Bug #1718895 reported by Martin André
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Martin André

Bug Description

The "chmod -R a+rx /openstack" commands we have in tripleo_kolla_template_overrides.j2 do not work the way we expect to, because it will ignore symlinks.

According to the chmod man page:

"For each symbolic link listed on the command line, chmod changes the
permissions of the pointed-to file. In contrast, chmod ignores
symbolic links encountered during recursive directory traversals."

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/506573
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=0460c8088d892913559a657168d8026b9f942db9
Submitter: Jenkins
Branch: master

commit 0460c8088d892913559a657168d8026b9f942db9
Author: Martin André <email address hidden>
Date: Fri Sep 22 11:22:33 2017 +0200

    Fix healthchecks permissions

    Set the permissions on the files rather than recursively on the
    directory otherwise symlinks are ignored.

    According to the chmod man page:

    "For each symbolic link listed on the command line, chmod changes the
    permissions of the pointed-to file. In contrast, chmod ignores
    symbolic links encountered during recursive directory traversals."

    Closes-Bug: #1718895
    Change-Id: I3c6545e0be2f70a0f7e90fbf9fda2646c36217dd

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 8.0.0

This issue was fixed in the openstack/tripleo-common 8.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/524104

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/pike)

Reviewed: https://review.openstack.org/524104
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7596f4a2b9819f2b582188d5d4360dd8f2eb17ff
Submitter: Zuul
Branch: stable/pike

commit 7596f4a2b9819f2b582188d5d4360dd8f2eb17ff
Author: Martin André <email address hidden>
Date: Fri Sep 22 11:22:33 2017 +0200

    Fix healthchecks permissions

    Set the permissions on the files rather than recursively on the
    directory otherwise symlinks are ignored.

    According to the chmod man page:

    "For each symbolic link listed on the command line, chmod changes the
    permissions of the pointed-to file. In contrast, chmod ignores
    symbolic links encountered during recursive directory traversals."

    Closes-Bug: #1718895
    Change-Id: I3c6545e0be2f70a0f7e90fbf9fda2646c36217dd
    (cherry picked from commit 0460c8088d892913559a657168d8026b9f942db9)
    Conflicts:
          container-images/tripleo_kolla_template_overrides.j2

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 7.6.10

This issue was fixed in the openstack/tripleo-common 7.6.10 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.