opendaylight container fails to build using kolla build

[John Trowbridge]

We added conditional inclusion of an ODL container with https://review.openstack.org/498383. (and then backported that to pike?)

The problem is that the ODL container fails to build using kolla-build[1] and a long with the conditionals we add to the jinja version of the container list, we also put it into the generic untemplated container list. We use the generic list in the periodic job which builds containers to promote, so the containers in that list need to actually be buildable.

[1] https://review.rdoproject.org/jenkins/job/periodic-tripleo-centos-7-pike-containers-build/79/console

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/506333

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/506334

[Janki Chhatbar (jankihchhatbar)]

Kolla-build fails for ODL because tripleo_kolla_template_overrides.j2 disables external repo [1] to get packages from Delorean repo and ODL is not present in Delorean. So, kolla errors out with

INFO:kolla.image.build.opendaylight:No package opendaylight available.

This patch [2] adds ODL repo to opendaylight_header. Once [2] is merged, I doubt if this would be still valid.

[1]. https://github.com/openstack/tripleo-common/blob/master/container-images/tripleo_kolla_template_overrides.j2#L4
[2]. https://review.openstack.org/#/c/502915/

[Janki Chhatbar (jankihchhatbar)]

Bug was this - https://bugs.launchpad.net/tripleo/+bug/1716604

[Janki Chhatbar (jankihchhatbar)]

s/was/for/ in comment #4

[John Trowbridge (trown)]

https://review.openstack.org/506604 is a better fix

[John Trowbridge (trown)]

replied before seeing comments here... https://review.openstack.org/506604 is just the pike backport of https://review.openstack.org/#/c/502915/

This is better than removing opendaylight container from build, just need to merge the pike backport and we should be good.

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Trowbridge (<email address hidden>) on branch: master
Review: https://review.openstack.org/506333
Reason: fixing the build is better:

https://review.openstack.org/#/q/I27a49fa32420cb5f44ad516c5d65949a8f62cf29

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Trowbridge (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/506334
Reason: fixing the build is better:

https://review.openstack.org/#/q/I27a49fa32420cb5f44ad516c5d65949a8f62cf29

[John Trowbridge (trown)]

https://review.openstack.org/#/c/506604/ merged so this is now fixed.