stonith property is never enabled even with EnableFencing: true

[Michele Baldessari]

Even though my template had the following:
parameter_defaults:
  EnableFencing: true
  FencingConfig:
    devices:
    - agent: fence_ipmilan
      host_mac: 00:92:bb:63:40:3d
      params:
        login: admin
        ipaddr: 192.168.24.1
        ipport: 6230
        passwd: password
        lanplus: 1
....

The deploy did not have stonith enabled:
Cluster Properties:
 cluster-infrastructure: corosync
 cluster-name: tripleo_cluster
 dc-version: 1.1.16-12.13.el7.centos-94ff4df
 have-watchdog: false
 redis_REPL_INFO: overcloud-controller-0
 stonith-enabled: false

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/504425

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/504425
Committed: https://git.openstack.org/cgit/openstack/puppet-pacemaker/commit/?id=a1c06f000779941cc998df71a8ed2f8157ad6d21
Submitter: Jenkins
Branch: master

commit a1c06f000779941cc998df71a8ed2f8157ad6d21
Author: Michele Baldessari <email address hidden>
Date: Fri Sep 15 16:48:56 2017 +0200

    Fix brokenness when changing the value of an existing property

    In TripleO we set the 'stonith-enabled' property to false
    at the beginning of the installation and then set it to true
    towards the end of the install. The reason this is not working
    is that the exist? function only greps for the property's
    existance and does not verify if the value is the one
    that the puppet module is trying to set.

    Fix this by making sure we also check for the expected value.
    We do this only if the expected 'ensure' status of the resource
    is set to 'present'

    Change-Id: Ia28d14d1763373494ae0bfc37d53d1fabc304d1e
    Closes-Bug: #1717531

[Michele Baldessari (michele)]

Turns out only a puppet-pacemaker fix was needed. Nothing to be done in TripleO

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-pacemaker 0.7.0 release.