downloaded deploy steps playbook starts at step 0

[James Slagle]

When you download the ansible playbooks for an overcloud with "config download" the playbook uses a sequence that starts at 0 to iterate through the deploy steps. The sequence number gets set as the hieradata step value.

It should start at 1 instead of 0 since the first step in numbered 1 in all our puppet manifests.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/504086

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/504086
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=320f80dbae3bb7b8b57239a5da99c0020a7f8a12
Submitter: Jenkins
Branch: master

commit 320f80dbae3bb7b8b57239a5da99c0020a7f8a12
Author: James Slagle <email address hidden>
Date: Thu Sep 14 09:31:58 2017 -0600

    Start sequence at 1 for deploy steps playbook

    We should start the sequence at 1 instead of 0, since all our puppet
    manifests assume the first step is 1. Trying to run our puppet manifests
    with a hieradata value of step=0 actually results in an error because no
    classes are included.

    Change-Id: I93dc8b4cefbd729ba7afa3a4d81b4ac95344cac2
    Closes-Bug: #1717292

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/522803

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/522803
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9e0b4d308807cfa27f69d73446f323cec0d0c837
Submitter: Zuul
Branch: stable/pike

commit 9e0b4d308807cfa27f69d73446f323cec0d0c837
Author: James Slagle <email address hidden>
Date: Thu Sep 14 09:31:58 2017 -0600

    Start sequence at 1 for deploy steps playbook

    We should start the sequence at 1 instead of 0, since all our puppet
    manifests assume the first step is 1. Trying to run our puppet manifests
    with a hieradata value of step=0 actually results in an error because no
    classes are included.

    Change-Id: I93dc8b4cefbd729ba7afa3a4d81b4ac95344cac2
    Closes-Bug: #1717292
    (cherry picked from commit 320f80dbae3bb7b8b57239a5da99c0020a7f8a12)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.6 release.