tripleo-ui cannot set default container image parameters

[Steve Baker]

Currently tripleo-heat-templates has no defaults for the mandatory container image parameters which are provided by including the environment file generated by running "openstack overcloud container image prepare". The TripleO UI cannot run prepare, so it cannot currently deploy an overcloud with containers.

The best short-term fix for now would be to include a prepare action in the plan_management workbook, so that the UI can have a default container environment generated. Eventually the UI should be able to pass parameters to do any required image management, but this bug is just to track being able to deploy via the UI with the configured defaults.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/503296

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/507720

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steve Baker (<email address hidden>) on branch: master
Review: https://review.openstack.org/507720
Reason: Actually we've just decided that the prepare action should run always in the UI and the CLI. So we don't need to switch it on in the UI.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/503296
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=b7ddde426aa3594fad106b8d8a6910965bfa1c8d
Submitter: Zuul
Branch: master

commit b7ddde426aa3594fad106b8d8a6910965bfa1c8d
Author: Steve Baker <email address hidden>
Date: Tue Sep 12 21:50:55 2017 +0000

    Action to always populate container image parameters

    Currently the UI cannot deploy with containers because the mandatory
    container parameters are not set. Also a CLI will not deploy unless
    passed an environment generated by the "images prepare" call.

    This change adds an action in the create_deployment_plan and
    update_deployment_plan workflows which does a container prepare with
    the default options, so that the mandatory image parameters are always
    populated with values which will work.

    Change-Id: Ibce7658468c1b3689a7481deb94dd43e1f3ead52
    Closes-Bug: #1716778

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/515232

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/517590

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/515232
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=ae128f4978d4e86656a06ddc24fde3cd6f2797c2
Submitter: Zuul
Branch: stable/pike

commit ae128f4978d4e86656a06ddc24fde3cd6f2797c2
Author: Steve Baker <email address hidden>
Date: Tue Sep 12 21:50:55 2017 +0000

    Action to always populate container image parameters

    Currently the UI cannot deploy with containers because the mandatory
    container parameters are not set. Also a CLI will not deploy unless
    passed an environment generated by the "images prepare" call.

    This change adds an action in the create_deployment_plan and
    update_deployment_plan workflows which does a container prepare with
    the default options, so that the mandatory image parameters are always
    populated with values which will work.

    Change-Id: Ibce7658468c1b3689a7481deb94dd43e1f3ead52
    Closes-Bug: #1716778
    (cherry picked from commit b7ddde426aa3594fad106b8d8a6910965bfa1c8d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517590
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c6a986665568fbc458c3e725c1a31e0fcf8c8af3
Submitter: Zuul
Branch: stable/pike

commit c6a986665568fbc458c3e725c1a31e0fcf8c8af3
Author: Julie Pichon <email address hidden>
Date: Tue Oct 31 15:30:38 2017 +0000

    Fix typos in container_images_prepare failure task names

    The message tasks in case of failures should reference the task to
    prepare the container images itself. In the case of create_plan, it
    would return a message for the wrong task, and in the case of
    update_plan I think it would fail altogether. This now references the
    correct task name.

    Related-Bug: #1716778
    Change-Id: Ie05bd113b8c20ee95aef82b07c63a9591baab98a
    (cherry picked from commit 07f21db70c842d7c7d0ef6c3f6e4c3459c3c40a4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 7.6.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.2.0 release.