devmode.sh with OVB should support all the feature sets supported by non-ovb deployments.

[unmesh desale]

Description
============

Developers are able to deploy only few feature sets (out of 31 sets) whose names are marked with 'ovb' using quickstart. Developers should be able to deploy most of the feature sets using devmode.sh with ovb option.

E.g. featureset024.yml doesn't work on OVB with devmode.sh. It throws below errors.

Actual results
================
+ bash quickstart.sh --bootstrap --working-dir /home/centos/.quickstart/ --tags all --no-clone --config /home/centos/.quickstart/config/general_config/featureset024.yml --environment /home/centos/.quickstart/config/environments/rdocloud.yml --extra-vars cleanup_stacks_keypairs=true --playbook baremetal-full-deploy.yml --release master-tripleo-ci localhost
New python executable in /home/centos/.quickstart/bin/python

+ ansible-playbook -vv /home/centos/.quickstart/playbooks/baremetal-full-deploy.yml -e @/home/centos/.quickstart/config/release/master-tripleo-ci.yml -e @/home/centos/.quickstart/config/general_config/featureset024.yml -e @/home/centos/.quickstart/config/general_config/featureset024.yml -e @/home/centos/.quickstart/config/environments/rdocloud.yml -e local_working_dir=/home/centos/.quickstart -e virthost=localhost -e cleanup_stacks_keypairs=true -t all,teardown-nodes

TASK [undercloud-setup : Copy instackenv.json to undercloud] *******************
task path: /home/centos/.quickstart/usr/local/share/ansible/roles/undercloud-setup/tasks/ovb_setup_connectivity.yml:2
Tuesday 29 August 2017 09:26:44 +0000 (0:00:01.914) 0:03:39.648 ********
skipping: [undercloud] => {"changed": false, "skip_reason": "Conditional check failed", "skipped": true}

TASK [undercloud-setup : Copy over setup undercloud connectivity script template] ***
task path: /home/centos/.quickstart/usr/local/share/ansible/roles/undercloud-setup/tasks/ovb_setup_connectivity.yml:7
Tuesday 29 August 2017 09:26:45 +0000 (0:00:00.542) 0:03:40.190 ********
skipping: [undercloud] => {"changed": false, "skip_reason": "Conditional check failed", "skipped": true}

TASK [undercloud-setup : Setup interfaces, connectivity on the undercloud] *****
task path: /home/centos/.quickstart/usr/local/share/ansible/roles/undercloud-setup/tasks/ovb_setup_connectivity.yml:13
Tuesday 29 August 2017 09:26:45 +0000 (0:00:00.378) 0:03:40.568 ********
skipping: [undercloud] => {"changed": false, "skip_reason": "Conditional check failed", "skipped": true}

It skips many of the important steps and finally throws below error.

TASK [validate-ipmi : Run the validate IPMI overclcoud connection script] ******
task path: /home/centos/.quickstart/usr/local/share/ansible/roles/validate-ipmi/tasks/main.yml:14
Tuesday 29 August 2017 09:41:06 +0000 (0:00:01.518) 0:18:00.679 ********
fatal: [undercloud]: FAILED! => {"changed": true, "cmd": "\"/home/stack\"/validate-overcloud-ipmi-connection.sh", "delta": "0:00:00.004381", "end": "2017-08-29 09:41:07.204395", "failed": true, "rc": 1, "start": "2017-08-29 09:41:07.200014", "stderr": "+ [[ ! -f /home/stack/instackenv.json ]]\n+ echo 'File \"instackenv.json\" is not in the working directory, aborting.'\n+ exit 1", "stdout": "File \"instackenv.json\" is not in the working directory, aborting.", "stdout_lines": ["File \"instackenv.json\" is not in the working directory, aborting."], "warnings": []}

Expected results
=================
devmode.sh on OVB should support most of the featuresets that works non-ovb deployments.
I need modify ovb-minimal-pacemaker-public-bond.yml file to include ceph related changes.

This is just one example, there could be different issues while supporting all other feature sets.

[wes hayutin (weshayutin)]

Check the logs directory of upstream CI...
Note: logs/reproducer-quickstart.sh

Give it a go