Clean up fluentd service implementation

Bug #1715187 reported by Lars Kellogg-Stedman on 2017-09-05
4
Affects Status Importance Assigned to Milestone
tripleo
Medium
Juan Badia Payno

Bug Description

The fluentd service implementation in tripleo-heat-templates predates the service_config_settings configuration mechanism, and necessitated some changes in common/services.yaml that would no longer be necessary with service_configs_setting.

We should re-implement the fluentd implementation using this new mechanism and remove the changes in common/services.yaml when they are no longer necessary.

Changed in tripleo:
assignee: nobody → Lars Kellogg-Stedman (larsks)
status: New → In Progress
Lars Kellogg-Stedman (larsks) wrote :

With the change introduced in https://review.openstack.org/500935, per-service configuration can be specified in a service template like this:

       service_config_settings:
         fluentd:
           tripleo_fluentd_groups_nova_api:
             - nova
           tripleo_fluentd_sources_nova_api:
             - type: tail
               tag: openstack.nova.api
               path: /var/log/nova/nova-api.log

Subsequent patches to t-h-t will implement this change.

Changed in tripleo:
milestone: none → queens-1
importance: Undecided → Medium

Fix proposed to branch: master
Review: https://review.openstack.org/501458

Fix proposed to branch: master
Review: https://review.openstack.org/502180

Fix proposed to branch: master
Review: https://review.openstack.org/502181

Fix proposed to branch: master
Review: https://review.openstack.org/502182

Changed in tripleo:
assignee: Lars Kellogg-Stedman (larsks) → Juan Badia Payno (jbadiapa)
Changed in tripleo:
milestone: queens-1 → queens-2

Reviewed: https://review.openstack.org/501457
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f982eb55c4be728060fb7d8d036c98a4721cb155
Submitter: Zuul
Branch: master

commit f982eb55c4be728060fb7d8d036c98a4721cb155
Author: Lars Kellogg-Stedman <email address hidden>
Date: Thu Aug 24 21:22:57 2017 -0700

    logging: merge fluentd-client and fluentd-base

    The fluentd implementation was originally split across multiple files
    in order to support both client and server services. we ultimately
    decided to only implement the client as part of tripleo so this
    division is no longer necessary. This commit merges
    fluentd-client.yaml and fluentd-base.yaml into fluentd.yaml, and
    renames things appropriately.

    Partial-bug: #1715187
    Depends-On: Iace34b7baae8822d2233d97adabf6ebc8833adab
    Change-Id: Idb9886f04d56ffc75a78c4059ff319b58b4acf9f

Changed in tripleo:
milestone: queens-2 → queens-3

Reviewed: https://review.openstack.org/500935
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=58355c95b71ead94e78e0bcdf438375de97f4492
Submitter: Zuul
Branch: master

commit 58355c95b71ead94e78e0bcdf438375de97f4492
Author: Lars Kellogg-Stedman <email address hidden>
Date: Mon Aug 21 15:18:03 2017 -0400

    logging: support service_config_settings configuration mechanism

    This commit implements the necessary support in puppet-tripleo to
    process fluentd configuration delivered via service_config_settings.

    Added the fluentd unit test regarding the new configuration:
    - A file by service
    - Added the group to the fluentd user

    Partial-bug: #1715187
    Change-Id: I2b057190ec0e4e75ee4ee47ebe0164c2644e5ab7

Reviewed: https://review.openstack.org/530780
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=c1ba5f7316167179685a3bcfcc1399a2817767a3
Submitter: Zuul
Branch: master

commit c1ba5f7316167179685a3bcfcc1399a2817767a3
Author: Juan Badia Payno <email address hidden>
Date: Tue Jan 2 18:33:50 2018 +0100

    Fluentd: Transform path by service

    Currently, the configuration delivered via
    service_config_settings does not provide the
    transformation path regarding the logs for
    containerized deployments. So logs are not
    correctly configured on fluentd on containerized
    deployments.

    This path added this feature so the logs are
    properly located on fluentd configuration.

    Added unit test for this issue

    Partial-bug: #1715187
    Partial-bug: #1716427
    Change-Id: Ie7df4b8b94cb0ae38096ab95800f211ef1cd8455

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/502182
Reason: Per policy, this patch will be abandoned: https://github.com/openstack/tripleo-specs/blob/master/specs/policy/patch-abandomment.rst#when-to-abandon

You can restore it at anytime if you think the patch will be updated.

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/502181
Reason: Per policy, this patch will be abandoned: https://github.com/openstack/tripleo-specs/blob/master/specs/policy/patch-abandomment.rst#when-to-abandon

You can restore it at anytime if you think the patch will be updated.

Changed in tripleo:
milestone: queens-3 → queens-rc1

Reviewed: https://review.openstack.org/539110
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=42a869fcf4b13cd8f1c88b0ec2ff5efefe8d2e0f
Submitter: Zuul
Branch: master

commit 42a869fcf4b13cd8f1c88b0ec2ff5efefe8d2e0f
Author: Juan Badia Payno <email address hidden>
Date: Tue Jan 30 07:59:50 2018 +0100

    Fluentd: fixed configuration by service

    The configuration file by service was not
    properly configured.

    Also clean some double tasks on the tests

    Change-Id: I3149902401d68d6fd236073a73a20f982d4b952a
    Closes-Bug: #1746952
    Related-Bug: #1715187

Reviewed: https://review.openstack.org/501458
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b20bce1bf02889b05d07eb41ceef02affbc458a3
Submitter: Zuul
Branch: master

commit b20bce1bf02889b05d07eb41ceef02affbc458a3
Author: Lars Kellogg-Stedman <email address hidden>
Date: Thu Aug 24 21:29:44 2017 -0700

    logging: use service_config_settings for fluentd

    The initial fluentd client implementation predates the introduction of
    service_config_settings, and necessitated some invasive changes to
    what is now common/serivces.yaml. This commit modifies existing
    services to use the service_config_settings based configuration
    mechanism supported by more recent versions of the fluentd support in
    puppet-tripleo.

    Partial-bug: #1715187
    Depends-On: I3149902401d68d6fd236073a73a20f982d4b952a
    Depends-On: I2b057190ec0e4e75ee4ee47ebe0164c2644e5ab7
    Depends-On: Ie7df4b8b94cb0ae38096ab95800f211ef1cd8455
    Change-Id: I28028ffa00df2da8e0478a551d3de89c3ee46e1f

Changed in tripleo:
milestone: queens-rc1 → rocky-1
Changed in tripleo:
milestone: rocky-1 → rocky-2
Changed in tripleo:
milestone: rocky-2 → rocky-3

Change abandoned by Lars Kellogg-Stedman (<email address hidden>) on branch: master
Review: https://review.openstack.org/502180

Change abandoned by Lars Kellogg-Stedman (<email address hidden>) on branch: master
Review: https://review.openstack.org/502181

Change abandoned by Lars Kellogg-Stedman (<email address hidden>) on branch: master
Review: https://review.openstack.org/502182

Changed in tripleo:
milestone: rocky-3 → rocky-rc1
Changed in tripleo:
milestone: rocky-rc1 → stein-1
Changed in tripleo:
milestone: stein-1 → stein-2
Changed in tripleo:
milestone: stein-2 → stein-3
Changed in tripleo:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers