overcloud image prepare command doesn't filter our services that are disabled

Bug #1714296 reported by Martin André on 2017-08-31
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Martin André

Bug Description

Emilien noticed in https://review.openstack.org/#/c/496950/ that the 'openstack overcloud container image prepare' command was still pulling the aodh containers even though the telemetry services were disabled in the CI job:

http://logs.openstack.org/50/496950/2/check/gate-tripleo-ci-centos-7-containers-multinode/d1e9d2b/logs/undercloud/home/jenkins/overcloud_prep_containers.log.txt.gz#_2017-08-30_23_47_24

tripleoclient looks only at the resource registry to check if a service points to a dockerized one without looking at whether the service is enabled or not. We need to match it with the role data.

Fix proposed to branch: master
Review: https://review.openstack.org/499704

Changed in tripleo:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/499704
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=954ed904356df39d57b058e16b0dde26ea0b1b66
Submitter: Jenkins
Branch: master

commit 954ed904356df39d57b058e16b0dde26ea0b1b66
Author: Martin André <email address hidden>
Date: Thu Aug 31 17:38:24 2017 +0200

    Filter out disabled services from prepare command

    Previously, the `openstack overcloud container image prepare` looked
    only at the resource registry -- checking if a resource pointed to
    a containerized service -- to determine which images to use without
    looking at the list of services that are enabled or not per roles.

    This commit introduces a new '--roles-file' option to the command to
    specify the path to the roles file when not using the default.

    Closes-Bug: #1714296
    Change-Id: I0188df062bd341dcf4791bfa9c9d0f1ad7f9396e

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/500225
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=d8eeff8301bda9b53272cac1586bd854a1018610
Submitter: Jenkins
Branch: stable/pike

commit d8eeff8301bda9b53272cac1586bd854a1018610
Author: Martin André <email address hidden>
Date: Thu Aug 31 17:38:24 2017 +0200

    Filter out disabled services from prepare command

    Previously, the `openstack overcloud container image prepare` looked
    only at the resource registry -- checking if a resource pointed to
    a containerized service -- to determine which images to use without
    looking at the list of services that are enabled or not per roles.

    This commit introduces a new '--roles-file' option to the command to
    specify the path to the roles file when not using the default.

    Closes-Bug: #1714296
    Change-Id: I0188df062bd341dcf4791bfa9c9d0f1ad7f9396e
    (cherry picked from commit 954ed904356df39d57b058e16b0dde26ea0b1b66)

tags: added: in-stable-pike

This issue was fixed in the openstack/python-tripleoclient 7.3.0 release.

This issue was fixed in the openstack/python-tripleoclient 8.0.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers